fix(traffic_light_classifier): fix zero size roi bug #7608
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Aug 7, 2024 in 34s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.31 (9.46 -> 9.15)
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method traffic_light_classifier_node.cpp: TrafficLightClassifierNodelet::imageRoiCallback
- Complex Conditional traffic_light_classifier_node.cpp: TrafficLightClassifierNodelet::imageRoiCallback
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
TrafficLightClassifierNodelet::imageRoiCallback increases in cyclomatic complexity from 14 to 19, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
TrafficLightClassifierNodelet::imageRoiCallback has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Bumpy Road Ahead
TrafficLightClassifierNodelet::imageRoiCallback increases from 3 to 4 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading