Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(traffic_light_classifier): fix zero size roi bug #7608

Merged
merged 6 commits into from
Aug 7, 2024
Merged

fix(traffic_light_classifier): fix zero size roi bug #7608

merged 6 commits into from
Aug 7, 2024

Commits on Aug 6, 2024

  1. fix: continue to process when input roi size is zero 

    Signed-off-by: Taekjin LEE <[email protected]>
    @technolojin
    technolojin committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e92cb9c View commit details
    Browse the repository at this point in the history

  2. fix: consider when roi size is zero, rois is empty 

    fix

Signed-off-by: Taekjin LEE <[email protected]>
    @technolojin
    technolojin committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1454a8e View commit details
    Browse the repository at this point in the history

  3. fix: use emplace_back instead of push_back for adding images and back… 

    …light indices

The code changes in `traffic_light_classifier_node.cpp` modify the way images and backlight indices are added to the respective vectors. Instead of using `push_back`, the code now uses `emplace_back`. This change improves performance and ensures proper object construction.

Signed-off-by: Taekjin LEE <[email protected]>
    @technolojin
    technolojin committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    021ede7 View commit details
    Browse the repository at this point in the history

  4. refactor: bring back for loop skim and output_msg filling 

    Signed-off-by: Taekjin LEE <[email protected]>
    @technolojin
    technolojin committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    09c4468 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. chore: refactor code to handle empty input ROIs in traffic_light_clas… 

    …sifier_node.cpp

Signed-off-by: Taekjin LEE <[email protected]>
    @technolojin
    technolojin committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    aec7e97 View commit details
    Browse the repository at this point in the history

  2. refactor: using index instead of vector length 

    Signed-off-by: Taekjin LEE <[email protected]>
    @technolojin
    technolojin committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    464d1f8 View commit details
    Browse the repository at this point in the history