Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lane_change): separate leading and trailing objects #8214

Merged
merged 2 commits into from
Aug 13, 2024
Merged

refactor(lane_change): separate leading and trailing objects #8214

merged 2 commits into from
Aug 13, 2024

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Separate lane change target objects to front and back in the filtering function to avoid redoing the front/back check in the isLaneChangePathSafe function

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the separate-front-and-behind-objects branch 2 times, most recently from d6c42b1 to 6435545 Compare August 6, 2024 08:50
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 mentioned this pull request Aug 6, 2024
Merged
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the separate-front-and-behind-objects branch from 6435545 to 72fae32 Compare August 9, 2024 04:43
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 9, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.66667% with 59 lines in your changes missing coverage. Please review.

Project coverage is 23.74%. Comparing base (e9dcf99) to head (6607895).
Report is 11 commits behind head on main.

Files Patch % Lines
...are_behavior_path_lane_change_module/src/scene.cpp 0.00% 43 Missing ⚠️
...vior_path_lane_change_module/src/utils/markers.cpp 0.00% 8 Missing ⚠️
...havior_path_lane_change_module/src/utils/utils.cpp 0.00% 5 Missing ⚠️
...ior_path_lane_change_module/utils/data_structs.hpp 33.33% 2 Missing ⚠️
...behavior_path_lane_change_module/src/interface.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8214      +/-   ##
==========================================
+ Coverage   23.72%   23.74%   +0.02%     
==========================================
  Files        1379     1379              
  Lines      101392   101382      -10     
  Branches    38522    38521       -1     
==========================================
+ Hits        24058    24076      +18     
+ Misses      74913    74867      -46     
- Partials     2421     2439      +18
Flag Coverage Δ *Carryforward flag
differential 15.66% <1.66%> (?)
total 23.76% <ø> (+0.03%) ⬆️ Carriedforward from 72fae32

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maxime-clem
maxime-clem approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good and a quick test in Psim did not reveal any problem.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the separate-front-and-behind-objects branch from 6607895 to 5118861 Compare August 13, 2024 01:42
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) August 13, 2024 01:42
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 4241a1d into autowarefoundation:main Aug 13, 2024
22 of 24 checks passed
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2024
@zulfaqar-azmi-t4
refactor(lane_change): separate leading and trailing objects (autowar…
8314f38 
…efoundation#8214)

* refactor(lane_change): separate leading and trailing objects

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Refactor to use common function

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the separate-front-and-behind-objects branch August 13, 2024 04:21
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
@zulfaqar-azmi-t4 @esteve
refactor(lane_change): separate leading and trailing objects (autowar…
8acb53a 
…efoundation#8214)

* refactor(lane_change): separate leading and trailing objects

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Refactor to use common function

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Aug 15, 2024
@zulfaqar-azmi-t4 @saka1-s
refactor(lane_change): separate leading and trailing objects (autowar…
34aa590 
…efoundation#8214)

* refactor(lane_change): separate leading and trailing objects

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Refactor to use common function

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
@zulfaqar-azmi-t4 @xtk8532704
refactor(lane_change): separate leading and trailing objects (autowar…
0a7ba4b 
…efoundation#8214)

* refactor(lane_change): separate leading and trailing objects

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Refactor to use common function

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
mbharatheesha pushed a commit to nobleo/autoware.universe that referenced this pull request Aug 16, 2024
@zulfaqar-azmi-t4 @mbharatheesha
refactor(lane_change): separate leading and trailing objects (autowar…
7874226 
…efoundation#8214)

* refactor(lane_change): separate leading and trailing objects

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Refactor to use common function

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Mukunda Bharatheesha <[email protected]>
mbharatheesha pushed a commit to nobleo/autoware.universe that referenced this pull request Aug 16, 2024
@zulfaqar-azmi-t4 @mbharatheesha
refactor(lane_change): separate leading and trailing objects (autowar…
a77fc35 
…efoundation#8214)

* refactor(lane_change): separate leading and trailing objects

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Refactor to use common function

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-clem maxime-clem maxime-clem approved these changes

@mkquda mkquda mkquda approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees

@maxime-clem maxime-clem

@mkquda mkquda

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zulfaqar-azmi-t4 @maxime-clem @mkquda