fix(tier4_planning_rviz_plugin): fix cppcheck warning of virtualCallInConstructor #8377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: taisa1 <[email protected]>
github-actions
bot
added
the
component:common
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
atsushi421
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8377 +/- ##
==========================================
+ Coverage 23.88% 29.25% +5.36%
==========================================
Files 1380 1610 +230
Lines 101584 119455 +17871
Branches 38637 51468 +12831
==========================================
+ Hits 24267 34949 +10682
- Misses 74887 75223 +336
- Partials 2430 9283 +6853
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Aug 6, 2024
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…nConstructor (autowarefoundation#8377) fix: deal with virtualCallInConstructor warning Signed-off-by: taisa1 <[email protected]> Co-authored-by: Ryuta Kambe <[email protected]> Signed-off-by: xtk8532704 <[email protected]>
taisa1
deleted the
fix_virtual_call_in_constructor_tier4_planning_rviz_plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix based on cppcheck warning
virtualCallInConstructor.Related links
Private Links:
How was this PR tested?
Only checked if build succeeded.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.