Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(traffic_light_classifier): fix traffic light monitor warning #8412

Conversation

zusizusi
Copy link
Contributor

@zusizusi zusizusi commented Aug 8, 2024

Description

This PR solves the problem that the traffic light system monitor outputs WARNING.
The WARNING was caused by the node not always outputting a topic.

Related links

#7608

How was this PR tested?

Tested on actual vehicle

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin self-assigned this Aug 8, 2024
@technolojin technolojin enabled auto-merge (squash) August 8, 2024 12:09
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.70%. Comparing base (861317d) to head (2d15477).
Report is 16 commits behind head on main.

Files Patch % Lines
...t_classifier/src/traffic_light_classifier_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8412      +/-   ##
==========================================
- Coverage   23.71%   23.70%   -0.01%     
==========================================
  Files        1378     1378              
  Lines      101354   101345       -9     
  Branches    38500    38493       -7     
==========================================
- Hits        24034    24028       -6     
+ Misses      74826    74823       -3     
  Partials     2494     2494              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 23.70% <ø> (-0.01%) ⬇️ Carriedforward from 861317d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin merged commit ba34878 into autowarefoundation:main Aug 8, 2024
38 of 39 checks passed
zusizusi added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2024
zusizusi added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2024
…owarefoundation#8412) (#1455)

fix traffic light monitor warning

Signed-off-by: Sho Iwasawa <[email protected]>
Co-authored-by: Naophis <[email protected]>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Aug 9, 2024
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…owarefoundation#8412)

fix traffic light monitor warning

Signed-off-by: Sho Iwasawa <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants