refactor(autoware_pointcloud_preprocessor): rework radius search 2d outlier filter parameters #8474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <[email protected]>
github-actions
bot
added
type:documentation
vividf
changed the title
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
vividf
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
YoshiRi and
yukkysaito
as code owners
vividf
added
the
tag:run-build-and-test-differential
badai-nguyen
added
the
tag:deploy-docs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8474 +/- ##
==========================================
- Coverage 25.23% 23.43% -1.81%
==========================================
Files 1325 1414 +89
Lines 98572 102436 +3864
Branches 38088 39077 +989
==========================================
- Hits 24874 24002 -872
- Misses 71156 75936 +4780
+ Partials 2542 2498 -44
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
knzo25
requested changes
Aug 19, 2024
...autoware_pointcloud_preprocessor/src/outlier_filter/radius_search_2d_outlier_filter_node.cpp
Outdated
Show resolved
Hide resolved
amadeuszsz
requested changes
Aug 20, 2024
...ing/autoware_pointcloud_preprocessor/schema/radius_search_2d_outlier_filter_node.schema.json
Outdated
Show resolved
Hide resolved
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
This was referenced Aug 20, 2024
|
@knzo25 Kindly ping |
emuemuJP
pushed a commit
to arayabrain/autoware.universe.origin
that referenced
this pull request
Sep 10, 2024
…utlier filter parameters (autowarefoundation#8474) * feat: rework radius search 2d outlier filter parameters Signed-off-by: vividf <[email protected]> * chore: fix schema Signed-off-by: vividf <[email protected]> * chore: explicit cast Signed-off-by: vividf <[email protected]> * chore: add boundary in schema Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]> Signed-off-by: emuemuJP <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes
nodelettonode.A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.
Related links
Parent Issue:
How was this PR tested?
ros2 launch autoware_pointcloud_preprocessor radius_search_2d_outlier_filter_node.launch.xmlNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.