refactor(autoware_pointcloud_preprocessor): rework filter parameters #8469
+85
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <[email protected]>
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
vividf
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
YoshiRi and
yukkysaito
as code owners
vividf
added
the
tag:run-build-and-test-differential
Signed-off-by: vividf <[email protected]>
vividf
added
the
tag:deploy-docs
knzo25
reviewed
Aug 20, 2024
| max_queue_size_ = static_cast<std::size_t>(declare_parameter("max_queue_size", 5)); | ||
| tf_input_frame_ = declare_parameter<std::string>("input_frame"); | ||
| tf_output_frame_ = declare_parameter<std::string>("output_frame"); | ||
| max_queue_size_ = declare_parameter<int64_t>("max_queue_size"); |
There was a problem hiding this comment.
Same as other PRs. Implicit cast -> static cast
There are initializations in the header that are only noise given how parameters are loaded. Since we are workin on this now, could you delete those?
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
This was referenced Aug 20, 2024
|
Note that this PR needs to be merged together with PR autowarefoundation/sample_sensor_kit_launch#104 in the common_sensor _launch |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes
A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.