Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_image_projection_based_fusion): roi cluster fusion has no existence probability update #8864

Conversation

technolojin
Copy link
Contributor

Description

The roi cluster fusion updates cluster classification from the roi to the cluster.
However, the existence probability was not updated.

This PR adds the existence probability update from the roi to the cluster.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.00%. Comparing base (9f7ba86) to head (b86720d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8864      +/-   ##
==========================================
- Coverage   28.00%   28.00%   -0.01%     
==========================================
  Files        1316     1316              
  Lines       98601    98607       +6     
  Branches    39771    39773       +2     
==========================================
+ Hits        27615    27616       +1     
- Misses      70840    70845       +5     
  Partials      146      146              
Flag Coverage Δ *Carryforward flag
differential 4.27% <0.00%> (?)
total 28.01% <ø> (+<0.01%) ⬆️ Carriedforward from 9f7ba86

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin force-pushed the fix/roi-cluster-fusion-existence-prob branch from 98d38ae to b86720d Compare September 24, 2024 01:40
@technolojin technolojin enabled auto-merge (squash) September 24, 2024 01:42
@technolojin technolojin merged commit 8573348 into autowarefoundation:main Sep 24, 2024
24 of 25 checks passed
@technolojin technolojin deleted the fix/roi-cluster-fusion-existence-prob branch September 24, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Development

Successfully merging this pull request may close these issues.

3 participants