Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_image_projection_based_fusion): roi cluster fusion has no existence probability update #8864

fix: add existence probability update, refactoring

b86720d
Select commit
Loading
Failed to load commit list.
Merged

fix(autoware_image_projection_based_fusion): roi cluster fusion has no existence probability update #8864

fix: add existence probability update, refactoring
b86720d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Sep 24, 2024 in 33s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.43 (6.33 -> 6.76)

  • Improving Code Health: 3 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Complex Method node.cpp: RoiClusterFusionNode::fuseOnSingleImage
  • Bumpy Road Ahead node.cpp: RoiClusterFusionNode::fuseOnSingleImage
  • Complex Conditional node.cpp: RoiClusterFusionNode::fuseOnSingleImage

Annotations

Check notice on line 210 in perception/autoware_image_projection_based_fusion/src/roi_cluster_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

RoiClusterFusionNode::fuseOnSingleImage decreases in cyclomatic complexity from 43 to 40, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 206 in perception/autoware_image_projection_based_fusion/src/roi_cluster_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Conditional

RoiClusterFusionNode::fuseOnSingleImage decreases from 3 complex conditionals with 7 branches to 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check notice on line 210 in perception/autoware_image_projection_based_fusion/src/roi_cluster_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Bumpy Road Ahead

RoiClusterFusionNode::fuseOnSingleImage decreases from 6 to 5 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.