Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ekf_localizer): add autoware prefix to ekf_localizer #119

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Sep 17, 2024

Description

This PR will add the autoware_ prefix to ekf_localizer.
Also added autoware_ prefix to gyro_odometer which was not update for the case of autoware_gyro_odometer update.

Reflect the change of autowarefoundation/autoware.universe#8888

Related links

autowarefoundation/autoware.universe#8888

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: a-maumau <[email protected]>
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I was not aware of the gyro_odometer either.
LGTM

@SakodaShintaro SakodaShintaro merged commit 7c5f721 into autowarefoundation:main Sep 18, 2024
36 checks passed
@a-maumau a-maumau deleted the mau/ref/localization/ekf_localizer branch September 19, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants