Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): improve stop and cruise behavior for cut-in & out #1142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Aug 27, 2024

Description

Related links

Tests performed

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54
Copy link
Member Author

brkay54 commented Sep 18, 2024

Thank you for your review, @yuki-takagi-66 -san.

I appreciate your insights and understand your concerns. I've already incorporated the stop_obstacle_type.outside.*** feature and conducted further tests today. The functionality is performing as expected. I have updated the parameter file in the autoware_launch pull request #1142, setting the stop parameters for outside pedestrians and bicycles to false.
However, considering the peculiarities of dense urban environments, I propose enabling this feature for such areas. I am also open to your suggestions and look forward to your thoughts on this approach.

brkay54 added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant