feat(system_error_monitor): delete system error monitor #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TetsuKawa <[email protected]>
TetsuKawa
requested review from
ito-san,
isamu-takagi,
shmpwk,
tkimura4,
yukkysaito,
mitsudome-r and
xmfcx
as code owners
github-actions
bot
added
component:system
|
Should there be any announcements done in GitHub Discussions and explain about how it was replaced with diagnostic_graph_aggregator? |
ito-san
added
tag:run-build-and-test-differential
enhancement
shmpwk
approved these changes
Sep 24, 2024
|
@mitsudome-r |
yukkysaito
approved these changes
Sep 24, 2024
rej55
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Sep 24, 2024
…dation#1178) feat: delete system error monitor Signed-off-by: TetsuKawa <[email protected]>
4 tasks
rej55
added a commit
to tier4/autoware_launch
that referenced
this pull request
Sep 24, 2024
feat(system_error_monitor): delete system error monitor (autowarefoundation#1178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove system error monitor from launch and config
Related links
autoware universe PR
Tests performed
Comfirmed no problem in launching Psim or Lsim.
Notes for reviewers
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.