-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved UI camera mapping #17244
Open
ickshonpe
wants to merge
11
commits into
bevyengine:main
Choose a base branch
from
ickshonpe:ui-camera-mapper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improved UI camera mapping #17244
+114
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d use them more efficiently.
Added Doc comments.
Fixed `boxed_shadow` camera query.
alice-i-cecile
added
C-Performance
A change motivated by improving speed, memory usage or compile times
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
labels
Jan 9, 2025
alice-i-cecile
added
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
A-Rendering
Drawing game state to the screen
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
labels
Jan 9, 2025
pcwalton
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. I'm not intimately familiar with the details of the UI code, so someone else should review this in addition to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Performance
A change motivated by improving speed, memory usage or compile times
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Two more optimisations for UI extraction:
Solution
Add a new system param
UiCameraMap
that resolves the correct render camera entity and only queries when necessary.I don't like the
UiCameraMap
+UiCameraMapper
implementation very much, maybe someone else can suggest a better construction.This is partly motivated by #16942 which adds further indirection and these changes would ameliorate that performance regression.