Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Selectable Components: Tile - Style] Website Doc #3901

Merged
merged 12 commits into from
Mar 4, 2024
Merged

[Selectable Components: Tile - Style] Website Doc #3901

merged 12 commits into from
Mar 4, 2024

Conversation

Kritvi-bhatia17
Copy link
Contributor

Closes #3861

  • Updated some of the Tile's doc images with what came out of our final design solutions.
  • Added 'Typography' section before the 'Structure' section.

@Kritvi-bhatia17 Kritvi-bhatia17 requested review from a team as code owners February 7, 2024 20:04
@vercel Vercel
Copy link

vercel bot commented Feb 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 6:01am

aagonzales
aagonzales reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small formatting thing. We try and always put tokens name in the inline code style.

src/pages/components/tile/style.mdx Outdated Show resolved Hide resolved
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Tile] Update Tile's Style Doc: Selectable Components [Selectable Components: Tile - Style] Website Doc Feb 15, 2024
This was referenced Mar 1, 2024
Closed
Closed
Closed
@Kritvi-bhatia17 Kritvi-bhatia17 enabled auto-merge (squash) March 1, 2024 20:39
@Kritvi-bhatia17 Kritvi-bhatia17 merged commit 6ec65db into carbon-design-system:main Mar 4, 2024
7 checks passed
@Kritvi-bhatia17 Kritvi-bhatia17 deleted the tiles_style/kritvi branch September 23, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@aagonzales aagonzales aagonzales approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Selectable Components: Tile] Website Doc
6 participants
@Kritvi-bhatia17 @alisonjoseph @aagonzales @tw15egan @laurenmrice @guidari