Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(percy): wait for fonts before snapshotting #18334

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

tay1orjones
Copy link
Member

Percy snapshots are still flaky wrt Plex, like this recent build.

This PR updates the visitStory helper for playwright to always wait for fonts to be ready before continuing.

Changelog

Changed

  • add page.evaluate call for document.fonts.ready to storybook e2e test utils

Testing / Reviewing

  • Percy builds on this PR should not show changes related to plex being unavailable

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 7c893d3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67857b39bd85960008cad56d
😎 Deploy Preview https://deploy-preview-18334--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7c893d3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67857b391d715f00086d6318
😎 Deploy Preview https://deploy-preview-18334--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 7c893d3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67857b399d0ef80008279218
😎 Deploy Preview https://deploy-preview-18334--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (e14e657) to head (7c893d3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18334   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4690     4640   -50     
=======================================
  Hits        12150    12150           
  Misses       2121     2121           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tay1orjones tay1orjones marked this pull request as ready for review January 14, 2025 14:00
@tay1orjones tay1orjones requested a review from a team as a code owner January 14, 2025 14:00
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@guidari guidari added this pull request to the merge queue Jan 14, 2025
Merged via the queue into carbon-design-system:main with commit b471140 Jan 14, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants