Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(percy): wait for fonts before snapshotting #18334

Merged
merged 2 commits into from
Jan 14, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: update to page.evaluate
  • Loading branch information
tay1orjones committed Jan 13, 2025
commit 7c893d3388025292515d0c6217e7330f8729d21b
4 changes: 3 additions & 1 deletion e2e/test-utils/storybook.js
Original file line number Diff line number Diff line change
@@ -38,7 +38,9 @@ async function visitStory(page, options) {
await expect(page).toContainAStory(options);

// Ensure Plex assets are fully available for accurate VRT
await page.waitForFunction(() => document.fonts.ready);
await page.evaluate(async () => {
await document.fonts.ready;
});
}

function getStoryUrl({ component, story, id }) {
Loading