Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(percy): wait for fonts before snapshotting #18334

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix(percy): wait for fonts before snapshotting #18334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b4da3
fix(percy): wait for fonts before snapshotting
tay1orjones Jan 13, 2025
7c893d3
chore: update to page.evaluate
tay1orjones Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions e2e/test-utils/storybook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ async function visitStory(page, options) {

await page.goto(url);
await expect(page).toContainAStory(options);

// Ensure Plex assets are fully available for accurate VRT
await page.evaluate(async () => {
await document.fonts.ready;
});
}

function getStoryUrl({ component, story, id }) {
Expand Down
Loading