-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reminder of workshop expectations #291
Conversation
Fixes 198
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries/lesson-development-training/compare/md-outputs..md-outputs-PR-291 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-09-29 15:06:42 +0000 |
Fixes #198 Missed # in the last comment so it didn't link |
Thanks @sstevens2, this looks good. Please could you move the CoC link reference to
|
Thanks Toby! Knew there must be someway to do that but I'm always uncertain about relative links in these contexts. Appreciate the clarification. |
Something I'm still unclear on, do I need to have something the references the |
@tobyhodges Let me know if the new sets of links seems right. They should all be to the relative ../CODE_OF_CONDUCT.md through |
the references in |
Thanks @sstevens2 what you've done is exactly what I had in mind. I had not anticipated that it would cause a conflict due to the linkref
I think we need to adjust the linkref in |
Ooo interesting! Easy fix, will fix now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for persevering, @sstevens2 🙌
Auto-generated via {sandpaper} Source : d5903f9 Branch : main Author : Toby Hodges <[email protected]> Time : 2023-09-29 15:08:24 +0000 Message : Merge pull request #291 from carpentries/sstevens2-iss198 Reminder of workshop expectations
Auto-generated via {sandpaper} Source : 1b4649b Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-29 15:09:35 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : d5903f9 Branch : main Author : Toby Hodges <[email protected]> Time : 2023-09-29 15:08:24 +0000 Message : Merge pull request #291 from carpentries/sstevens2-iss198 Reminder of workshop expectations
Fixes #198