chore: pull cometbft v0.34.35 #1495

rootulp · 2024-09-20T18:38:17Z

Closes #1468 by pulling upstream v0.34.35 with these notable merge conflicts:

Our repo upgraded Go past what upstream has so I choose to retain the more recent Go version

And these changes to make unit tests pass:

Refactor CI to run all tests in one execution. It takes the same time (4 mins) as it previously did. But now it's easier to reason about the flakes.
Included refactor: TestTxPool_ConcurrentTxs #1503
Included fix: TestTxPool_ConcurrentlyAddingTx #1501

FLUPs

Make it easier to pull upstream changes #1504
Opens TestTxMempool_ExpiredTxs_Timestamp flake #1502 and skips that test

Testing

I used go mod replace and verified that celestia-app can use this version of celestia-core.

single-node.sh
mocha.sh

…#766) * Fix `TestStateOversizedBlock` (celestiaorg#755) * Fix TestStateOversizedBlock * Moved `findBlockSizeLimit` together with other aux functions (cherry picked from commit c58597d656d5c816334aff9ea8e600bdbc534817) # Conflicts: # consensus/state_test.go * Revert "Fix `TestStateOversizedBlock` (celestiaorg#755)" This reverts commit e7d2a127a26d4d833bae3aef0917bb6bca2cda5b. * Fix `TestStateOversizedBlock` (celestiaorg#755) * Fix TestStateOversizedBlock * Moved `findBlockSizeLimit` together with other aux functions --------- Co-authored-by: Sergio Mena <[email protected]>

…#788) (cherry picked from commit ecd5ee112533cda28900cbd75afb349f67da3fa5) Co-authored-by: Sergio Mena <[email protected]>

…aorg#794) * Unsafe int cast in `kill` command (celestiaorg#783) * Unsafe int cast in `kill` command * Revert "Unsafe int cast in `kill` command" This reverts commit bbd649bd372ca90f83dea7b424d67dafbd9eb541. * Changed strategy (cherry picked from commit 03c5e7727a03983b54623e731d5d3d8dd4ac75ec) # Conflicts: # cmd/cometbft/commands/debug/kill.go * Revert "Unsafe int cast in `kill` command (celestiaorg#783)" This reverts commit b7ab279a6df1f062bec60bcf95947d2a87f4ccec. * Unsafe int cast in `kill` command (celestiaorg#783) * Unsafe int cast in `kill` command * Revert "Unsafe int cast in `kill` command" This reverts commit bbd649bd372ca90f83dea7b424d67dafbd9eb541. * Changed strategy --------- Co-authored-by: Sergio Mena <[email protected]>

…lestiaorg#805) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.17.0 to 1.18.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…#798) Replaced int64 with big.int Co-authored-by: Lasaro <[email protected]> Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: Thane Thomson <[email protected]>

…iaorg#829) (celestiaorg#838)

…elestiaorg#870) Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/slackapi/slack-github-action/releases) - [Commits](slackapi/slack-github-action@v1.23.0...v1.24.0) --- updated-dependencies: - dependency-name: slackapi/slack-github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…lestiaorg#871) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.18.0 to 1.19.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.18.0...v1.19.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…lestiaorg#909) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.19.0 to 1.20.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.19.0...v1.20.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

celestiaorg#890) (celestiaorg#927) * add a test to trigger the issue * add a fix (in particular, we track the sender when receiving a tx twice) * add a changelog * update fix and test wrt. v0.34.x --------- Co-authored-by: Daniel <[email protected]> Co-authored-by: Pierre Sutra <[email protected]>

…ackport celestiaorg#865) (celestiaorg#970) * fix: avoid recursive call after rename to (*PeerState).MarshalJSON (celestiaorg#865) * avoid recursive call after rename to (*PeerState).MarshalJSON * add test * add change doc * explain for nolint * fix lint * fix golangci-lint to v1.52.2 * fix golangci-lint to v1.52.2 * Revert "fix golangci-lint to v1.52.2" This reverts commit 598a9ef4c86fc29cf038251676c33a222217826c. * Revert "fix golangci-lint to v1.52.2" This reverts commit a8aad121e27382813e95b1911b1b560c62e1c7c3. * Reintroduced `cmtjson` * Avoid copying Mutex * Avoid copying Mutex -- 2nd try, more succint * Update .changelog/unreleased/bug-fixes/865-fix-peerstate-marshaljson.md * Update consensus/reactor_test.go --------- Co-authored-by: Sergio Mena <[email protected]> (cherry picked from commit f6ea09171a2bf9f695f59b65f5c51e4a8c168015) # Conflicts: # consensus/reactor_test.go * Revert "fix: avoid recursive call after rename to (*PeerState).MarshalJSON (celestiaorg#865)" * fix: avoid recursive call after rename to (*PeerState).MarshalJSON (celestiaorg#865) * avoid recursive call after rename to (*PeerState).MarshalJSON * add test * add change doc * explain for nolint * fix lint * fix golangci-lint to v1.52.2 * fix golangci-lint to v1.52.2 * Revert "fix golangci-lint to v1.52.2" This reverts commit 598a9ef4c86fc29cf038251676c33a222217826c. * Revert "fix golangci-lint to v1.52.2" This reverts commit a8aad121e27382813e95b1911b1b560c62e1c7c3. * Reintroduced `cmtjson` * Avoid copying Mutex * Avoid copying Mutex -- 2nd try, more succint * Update .changelog/unreleased/bug-fixes/865-fix-peerstate-marshaljson.md * Update consensus/reactor_test.go --------- Co-authored-by: Sergio Mena <[email protected]> --------- Co-authored-by: mmsqe <[email protected]> Co-authored-by: Sergio Mena <[email protected]>

* changelog: Clean up and reorder Signed-off-by: Thane Thomson <[email protected]> * changelog: Add missing entries Signed-off-by: Thane Thomson <[email protected]> * changelog: Release v0.34.29 Signed-off-by: Thane Thomson <[email protected]> * Rebuild changelog Signed-off-by: Thane Thomson <[email protected]> * version: Bump to v0.34.29 Signed-off-by: Thane Thomson <[email protected]> * test/e2e: Use Debian Bullseye as base image Golang recently started offering Debian Bookworm as the default distro for `golang:1.19`, which provides a newer version of RocksDB than what we support in cometbft-db. For now this pins the image to Bullseye, which is the base image we have been using for some time now. Signed-off-by: Thane Thomson <[email protected]> --------- Signed-off-by: Thane Thomson <[email protected]>

…lestiaorg#940) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.20.0 to 1.21.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.20.0...v1.21.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…tiaorg#977)

…estiaorg#976)

…g#942) Bumps [docker/login-action](https://github.com/docker/login-action) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2.1.0...v2.2.0) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…g#1000) * Add `CMT_HOME` (or remove it?) (celestiaorg#983) Closes celestiaorg#982 Added `CMT_HOME` everywhere `CMTHOME` is used. ### Notes to reviewers This could be fixed the opposite way, by removing the only reference to `CMT_HOME` in the code, and also the reference in `UPGRADING.md` (two lines of code). However, the reference in `UPGRADING.md`, which is part of our documentation, is already present in `v0.34.x` (not in `v0.37.x` though!). That's why this PR introduces `CMT_HOME` to work in equal conditions as `CMTHOME`. If reviewers lean toward removing `CMT_HOME` from the doc in `v0.34.x` (and unreleased `v0.38.x` and `main`), I can do it easily. --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit b7be568f4a59edf41942ec7e0e25edd72df604d8) # Conflicts: # cmd/cometbft/commands/root_test.go * Revert "Add `CMT_HOME` (or remove it?) (celestiaorg#983)" * Add `CMT_HOME` (or remove it?) (celestiaorg#983) Closes celestiaorg#982 Added `CMT_HOME` everywhere `CMTHOME` is used. This could be fixed the opposite way, by removing the only reference to `CMT_HOME` in the code, and also the reference in `UPGRADING.md` (two lines of code). However, the reference in `UPGRADING.md`, which is part of our documentation, is already present in `v0.34.x` (not in `v0.37.x` though!). That's why this PR introduces `CMT_HOME` to work in equal conditions as `CMTHOME`. If reviewers lean toward removing `CMT_HOME` from the doc in `v0.34.x` (and unreleased `v0.38.x` and `main`), I can do it easily. --- - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Sergio Mena <[email protected]>

…rg#1012) it'll make the handshake work with graceful shutdown(see: cosmos/cosmos-sdk#16202) handshake could be a long running process if there are many local blocks to replay, for example we use it to do profiling. Hope we can backport this to 0.34.x. --- - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments

…lestiaorg#1025) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.21.0 to 1.22.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.21.0...v1.22.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

celestiaorg#1047) Closes celestiaorg#666 This PR adds double quotes to `path` param of `/abci_query` endpoint. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit f6f13b1f67a54549d9f212a859ca4924d6ad9127) Co-authored-by: Steven Ferrer <[email protected]>

…lestiaorg#1070) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.22.0 to 1.23.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.22.0...v1.23.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…estiaorg#1069) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.7.0...v2.8.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…estiaorg#1099) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.8.0 to 2.9.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.8.0...v2.9.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…estiaorg#1127) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.9.0 to 2.9.1. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.9.0...v2.9.1) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…lestiaorg#1128) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.23.1 to 1.24.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.23.1...v1.24.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…lestiaorg#1162) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.24.0 to 1.25.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.24.0...v1.25.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* CV OnStop close evidenceStore * CV OnStop print db close * CV add changelog * CV update changelog with attribution (cherry picked from commit 48335a06f01524b036fde4dc1bab569bfc4ab9c7) Co-authored-by: Chill Validation <[email protected]>

…lestiaorg#1214) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.25.0 to 1.25.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.25.0...v1.25.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…elestiaorg#1079) (celestiaorg#1222) * Log proposer's address when correctly accepting a proposal (celestiaorg#1079) * Log proposer when logging received proposal * Addressed review comments * Promote updates to validator to Info level (cherry picked from commit cf230821c899f1f0cd3ef9cbbcc678ca01008d46) # Conflicts: # consensus/state.go # state/execution.go * Revert "Log proposer's address when correctly accepting a proposal (celestiaorg#1079)" This reverts commit 8ccdb00e9023da91ae324c86956ffe5a5851d1a3. * Log proposer's address when correctly accepting a proposal (celestiaorg#1079) * Log proposer when logging received proposal * Addressed review comments * Promote updates to validator to Info level --------- Co-authored-by: Sergio Mena <[email protected]>

…lestiaorg#1238) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.25.1 to 1.26.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.25.1...v1.26.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

rootulp · 2024-09-25T14:04:03Z

This PR is blocked because unit tests haven't successfully run. The flaky tests are:

e2e-test
Some test in github.com/tendermint/tendermint/store taking too long
TestTxPool_ConcurrentTxs: CI Test flake for TestTxPool_ConcurrentTxs #1194
TestTxPool_ConcurrentlyAddingTx TestTxPool_ConcurrentlyAddingTx is flaky #1383
TestByzantinePrevoteEquivocation
TestPruneBlocksPrunesTxs
TestTxMempool_ExpiredTxs_Timestamp

One idea is to avoid splitting the tests into random subgroups and instead run all the tests via one go test invocation. Based on experience in celestia-app that isn't any slower and often can be faster.

rootulp · 2024-09-25T17:56:19Z

CI is finally green 😌

cmwaters · 2024-09-25T20:05:09Z

abci/types/messages.go


 	"github.com/gogo/protobuf/proto"
 )

 const (
-	maxMsgSize = 104857600 // 100MB
+	maxMsgSize = math.MaxInt32 // 2GB


Do you know what this used for?

bfc3d09

cometbft/cometbft#1729

cmwaters · 2024-09-25T20:06:08Z

config/config.go

+	// Experimental parameters to limit gossiping txs to up to the specified number of peers.
+	// This feature is only available for the default mempool (version config set to "v0").
+	// We use two independent upper values for persistent and non-persistent peers.
+	// Unconditional peers are not affected by this feature.
+	// If we are connected to more than the specified number of persistent peers, only send txs to
+	// ExperimentalMaxGossipConnectionsToPersistentPeers of them. If one of those
+	// persistent peers disconnects, activate another persistent peer.
+	// Similarly for non-persistent peers, with an upper limit of
+	// ExperimentalMaxGossipConnectionsToNonPersistentPeers.
+	// If set to 0, the feature is disabled for the corresponding group of peers, that is, the
+	// number of active connections to that group of peers is not bounded.
+	// For non-persistent peers, if enabled, a value of 10 is recommended based on experimental
+	// performance results using the default P2P configuration.
+	ExperimentalMaxGossipConnectionsToPersistentPeers    int `mapstructure:"experimental_max_gossip_connections_to_persistent_peers"`
+	ExperimentalMaxGossipConnectionsToNonPersistentPeers int `mapstructure:"experimental_max_gossip_connections_to_non_persistent_peers"`


If I understand this correctly, this means that you can be connected to 20 peers but only gossip transactions (using the v0 mempool) for say 10 of those peers?

We don't use the v0 mempool so do we still want these changes?

We don't use the v0 mempool so do we still want these changes?

Node operators can still use the v0 mempool. FWIW I didn't selectively exclude any commits from v0.34.35. I pulled all upstream changes (including this one).

I don't see a strong reason to exclude this commit unless we're concerned it's dangerous or buggy. Now that you mention it, it does seem odd that an experimental feature was included in a patch release of CometBFT.

evan-forbes

this is always a ton of work, thanks a bunch @rootulp !!

mempool/v1/mempool_test.go

evan-forbes · 2024-09-27T15:18:47Z

types/validator.go

-	if len(v.Address) != crypto.AddressSize {
-		return fmt.Errorf("validator address is the wrong size: %v", v.Address)
+	addr := v.PubKey.Address()
+	if !bytes.Equal(v.Address, addr) {
+		return fmt.Errorf("validator address is incorrectly derived from pubkey. Exp: %v, got %v", addr, v.Address)


fwiw to other reviewers, here's the fix with statesync

GHSA-g5xx-c4hv-9ccc

types/validator_set.go

mergify bot and others added 30 commits May 1, 2023 21:08

Struct Client exposes sensitive data (celestiaorg#784) (celestiaorg…

49cf700

…#788) (cherry picked from commit ecd5ee112533cda28900cbd75afb349f67da3fa5) Co-authored-by: Sergio Mena <[email protected]>

Backport of PR celestiaorg#771 to 0.34 : big int parsing (celestiaorg…

30af8c2

…#798) Replaced int64 with big.int Co-authored-by: Lasaro <[email protected]> Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: Thane Thomson <[email protected]>

rpc: Remove response data from response failure logs (backport celest…

557ddea

…iaorg#829) (celestiaorg#838)

build(deps): Bump docker/build-push-action from 4.0.0 to 4.1.1 (celes…

c6615d3

…tiaorg#977)

build(deps): Bump docker/setup-buildx-action from 2.5.0 to 2.7.0 (cel…

90107ec

…estiaorg#976)

rootulp added 3 commits September 20, 2024 17:38

fix: TestSaveTxInfo

235840d

fix: TestLoadBlockPart

4610dac

ci: increase test timeout

61989fe

rootulp mentioned this pull request Sep 20, 2024

chore(deps): upgrade to btcsuite/btcd v2.3.4 celestiaorg/cosmos-sdk#415

Merged

ci: bump to 15m

77a3b09

rootulp mentioned this pull request Sep 24, 2024

docs: remove entire spec and leave only readme that points to Cometbft spec #1500

Open

3 tasks

ci: run all tests in one group

65ead60

rootulp force-pushed the rp/v0.34.35 branch from 533b7f3 to 65ead60 Compare September 25, 2024 14:11

rootulp added 4 commits September 25, 2024 11:26

fix: TestTxPool_ConcurrentlyAddingTx

6907f9c

refactor: TestTxPool_ConcurrentTxs

b8b2570

skip TestTxMempool_ExpiredTxs_Timestamp

660877c

fix: TestPruneBlocksPrunesTxs

1123aae

rootulp marked this pull request as ready for review September 25, 2024 17:55

rootulp requested a review from a team as a code owner September 25, 2024 17:55

rootulp requested review from cmwaters and staheri14 and removed request for a team September 25, 2024 17:55

rootulp requested review from evan-forbes and ninabarbakadze September 25, 2024 17:56

rootulp mentioned this pull request Sep 25, 2024

Make it easier to pull upstream changes #1504

Open

cmwaters reviewed Sep 25, 2024

View reviewed changes

evan-forbes approved these changes Sep 27, 2024

View reviewed changes

evan-forbes mentioned this pull request Sep 27, 2024

fix TestTxMempool_ExpiredTxs_Timestamp flakes #1506

Closed

rootulp requested review from cmwaters and rach-id September 30, 2024 14:03

rach-id approved these changes Sep 30, 2024

View reviewed changes

rootulp merged commit 65c778d into celestiaorg:v0.34.x-celestia Sep 30, 2024
15 checks passed

rootulp deleted the rp/v0.34.35 branch September 30, 2024 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: pull cometbft v0.34.35 #1495

chore: pull cometbft v0.34.35 #1495

rootulp commented Sep 20, 2024 •

edited

Loading

rootulp commented Sep 25, 2024 •

edited

Loading

rootulp commented Sep 25, 2024

cmwaters Sep 25, 2024

rootulp Sep 25, 2024

cmwaters Sep 25, 2024

cmwaters Sep 25, 2024

rootulp Sep 25, 2024 •

edited

Loading

evan-forbes left a comment

evan-forbes Sep 27, 2024

chore: pull cometbft v0.34.35 #1495

chore: pull cometbft v0.34.35 #1495

Conversation

rootulp commented Sep 20, 2024 • edited Loading

FLUPs

Testing

rootulp commented Sep 25, 2024 • edited Loading

rootulp commented Sep 25, 2024

cmwaters Sep 25, 2024

Choose a reason for hiding this comment

rootulp Sep 25, 2024

Choose a reason for hiding this comment

cmwaters Sep 25, 2024

Choose a reason for hiding this comment

cmwaters Sep 25, 2024

Choose a reason for hiding this comment

rootulp Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

evan-forbes left a comment

Choose a reason for hiding this comment

evan-forbes Sep 27, 2024

Choose a reason for hiding this comment

rootulp commented Sep 20, 2024 •

edited

Loading

rootulp commented Sep 25, 2024 •

edited

Loading

rootulp Sep 25, 2024 •

edited

Loading