-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add a Stylelint configuration that enforces use of logical properties #1713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaemonCahill
force-pushed
the
scottob-stylelint-logical-properties
branch
2 times, most recently
from
November 3, 2023 15:31
5a1ad6a
to
903295a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1713 +/- ##
==========================================
- Coverage 94.54% 94.40% -0.15%
==========================================
Files 653 652 -1
Lines 17683 17635 -48
Branches 5821 5800 -21
==========================================
- Hits 16719 16648 -71
- Misses 897 919 +22
- Partials 67 68 +1 ☔ View full report in Codecov by Sentry. |
DaemonCahill
force-pushed
the
scottob-stylelint-logical-properties
branch
from
November 6, 2023 21:41
bb873c4
to
bf37af5
Compare
DaemonCahill
force-pushed
the
scottob-stylelint-logical-properties
branch
from
November 7, 2023 21:12
48eb21d
to
effa8b6
Compare
DaemonCahill
force-pushed
the
scottob-stylelint-logical-properties
branch
2 times, most recently
from
November 8, 2023 17:00
fe70b26
to
ce20843
Compare
DaemonCahill
force-pushed
the
scottob-stylelint-logical-properties
branch
from
November 9, 2023 16:17
4b7803c
to
a0275f4
Compare
DaemonCahill
force-pushed
the
scottob-stylelint-logical-properties
branch
from
November 10, 2023 17:33
a0275f4
to
9ef6bae
Compare
DaemonCahill
force-pushed
the
scottob-stylelint-logical-properties
branch
from
November 13, 2023 18:50
55f6d01
to
4a10c2b
Compare
DaemonCahill
force-pushed
the
scottob-stylelint-logical-properties
branch
from
November 14, 2023 20:52
4a10c2b
to
75f4a8e
Compare
This reverts commit 5a040a8.
DaemonCahill
force-pushed
the
scottob-stylelint-logical-properties
branch
from
December 7, 2023 18:19
22f2b59
to
d02fa16
Compare
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that utilizes a Stylelint plugin to enforce usage of logical properties across all of our components. The
--fix
command was utilized to resolve all flagged physical properties to their logical equivalents.