Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a Stylelint configuration that enforces use of logical properties #1713

Closed
wants to merge 32 commits into from

Conversation

DaemonCahill
Copy link
Member

This is a draft PR that utilizes a Stylelint plugin to enforce usage of logical properties across all of our components. The --fix command was utilized to resolve all flagged physical properties to their logical equivalents.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c13b1f) 94.54% compared to head (9ddcab7) 94.40%.

❗ Current head 9ddcab7 differs from pull request most recent head d02fa16. Consider uploading reports for the commit d02fa16 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
- Coverage   94.54%   94.40%   -0.15%     
==========================================
  Files         653      652       -1     
  Lines       17683    17635      -48     
  Branches     5821     5800      -21     
==========================================
- Hits        16719    16648      -71     
- Misses        897      919      +22     
- Partials       67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaemonCahill DaemonCahill force-pushed the scottob-stylelint-logical-properties branch from bb873c4 to bf37af5 Compare November 6, 2023 21:41
@DaemonCahill DaemonCahill force-pushed the scottob-stylelint-logical-properties branch from 48eb21d to effa8b6 Compare November 7, 2023 21:12
@DaemonCahill DaemonCahill force-pushed the scottob-stylelint-logical-properties branch 2 times, most recently from fe70b26 to ce20843 Compare November 8, 2023 17:00
@DaemonCahill DaemonCahill force-pushed the scottob-stylelint-logical-properties branch from 4b7803c to a0275f4 Compare November 9, 2023 16:17
@DaemonCahill DaemonCahill force-pushed the scottob-stylelint-logical-properties branch from a0275f4 to 9ef6bae Compare November 10, 2023 17:33
@DaemonCahill DaemonCahill force-pushed the scottob-stylelint-logical-properties branch from 55f6d01 to 4a10c2b Compare November 13, 2023 18:50
@DaemonCahill DaemonCahill force-pushed the scottob-stylelint-logical-properties branch from 4a10c2b to 75f4a8e Compare November 14, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant