Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete PrintInfo() function from G4muDarkBremsstrahlung #38949

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

revering
Copy link

@revering revering commented Aug 2, 2022

Removed PrintInfo() function from G4muDarkBremsstrahlung to resolve #38935

The process generation ran successfully with PrintInfo() removed, and hopefully its removal will fix the IB compiler errors noted in the issue.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38949/31390

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

A new Pull Request was created by @revering for master.

It involves the following packages:

  • SimG4Core/CustomPhysics (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Aug 2, 2022

@cmsbuild, please test for CMSSW_12_5_G4VECGEOM_X

@civanch
Copy link
Contributor

civanch commented Aug 2, 2022

@revering , please, add he fix of G4muDarkBremsstahlungModel: substitute

element->GetA() by element->GetN()

and

double muMass = dp->GetDefinition()->GetPDGMass();

instead of hardcoded muon mass.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38949/31395

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

Pull request #38949 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

…le definition instead of hardcoded value

and use GetN instead of GetA to get target nucleon number.

Implement code-format fix for G4muDarkBremsstrahlungModel

Change G4muDarkBremsstrahlungModel to use Geant4 muon mass for
muon_mass_mev as well as GeV muon mass.
@revering
Copy link
Author

revering commented Aug 2, 2022

I've implemented the change to GetN() and using the Geant4 muon particle definition to get the muon mass instead of a hardcoded value. The muon mass is used in many functions, so I added it as a class member and initialized it with
muonMass = G4MuonMinus::MuonMinusDefinition()->GetPDGMass() / CLHEP::GeV
instead of using the dynamic particle.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38949/31396

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

Pull request #38949 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@qliphy
Copy link
Contributor

qliphy commented Aug 3, 2022

@revering Please also backport this to 12_4_X

@civanch
Copy link
Contributor

civanch commented Aug 3, 2022

please test

@civanch
Copy link
Contributor

civanch commented Aug 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor

civanch commented Aug 3, 2022

@revering , please make modification in 10_6 PR, make also backport of this PR to 12_4.

@qliphy
Copy link
Contributor

qliphy commented Aug 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72030c/26615/summary.html
COMMIT: 84f5634
CMSSW: CMSSW_12_5_X_2022-08-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38949/26615/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3677948
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3677912
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[G4VECGEOM_X] IB reports compiler errors for both gcc10 and gcc11.
5 participants