fix(jmx): restore error codes for auth and TLS connection failures #350
Conversation
|
/build_test |
|
Workflow started at 4/3/2024, 10:54:30 AM. View Actions Run. |
|
CI build and push: All tests pass ✅ (JDK21) |
|
No OpenAPI schema changes detected. |
|
/build_test |
|
Workflow started at 4/3/2024, 10:59:15 AM. View Actions Run. |
|
CI build and push: At least one test failed ❌ (JDK17) |
|
CI build and push: All tests pass ✅ (JDK21) |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
andrewazores
force-pushed
the
jmx-fail-response-status
branch
from
1f7be97
to
2606aee
Compare
|
/build_test |
|
Workflow started at 4/15/2024, 9:02:02 AM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #348
Description of the change:
Adds exception handling to the TargetConnectionManager's internal
Unipipeline, to catch and transform particular types of connection exceptions intoHttpExceptionwith the correct status codes that the previous API defined and which the UI expects.Motivation for the change:
This re-enables the ability for the UI to display the JMX auth and cert warning modals when attempting to connect to targets for which there are no correct stored credentials or which present an untrusted cert.
How to manually test:
smoketest.bash -Ot9093sample app, go to Events view. Templates and types should load.9094sample app, go to Events view. Connection should fail and UI should display auth modal.9095sample app, go to Events view. Connection should fail and UI should display cert modal.Current "bugs":
GET /api/v3/targets/{id}/recordingsendpoint for Cryostat 3.0 no longer initiates a direct JMX connection to the target as it did in previous releases. Instead, this endpoint only queries Cryostat's database for known ActiveRecordings. The JMX auth/cert failures would have been detected in the background when Cryostat discovered the target and attempted to connect. Related to feat(agent): enable Agent HTTP communications #342 (some of the refactoring done to do more synchronization of "external" active recordings) and [Epic] Redefine Target data model to allow multiple Connection URLs #71 (where targets' connection URLs would have a "connectable" state which could be used to flag and detect these cases).