Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fantasticon instead of gulp. #112

Draft
wants to merge 5 commits into
base: lgarron/biome
Choose a base branch
from
Draft

Conversation

lgarron
Copy link
Member

@lgarron lgarron commented Sep 12, 2023

Compared to our gulp pipeline, this is:

  • Faster
  • Much simpler
  • Easier to maintain
  • Not full of deprecated dependencies with vulnerabilities

This also changes the project organization to match other github.com/cubing projects more closely.

Closes:

Per discussion in #108 as well as several PRs and issues.
Compared to our `gulp` pipeline, this is:

- Faster
- Much simpler
- Easier to maintain
- Not full of deprecated dependencies with vulnerabilities

This also changes the project organization to match other `github.com/cubing` projects more closely.

Closes:
- #55
- #93
@lgarron lgarron requested a review from jfly September 12, 2023 08:45
@lgarron
Copy link
Member Author

lgarron commented Sep 12, 2023

@jfly: This still needs a few fixups, and updates to the generated site. But it looks like this this will work. Any thoughts?

@jfly
Copy link
Member

jfly commented Sep 12, 2023

fantasticon looks like a good alternative for us!

Can we do one thing at a time? That is, can we do the biomejs stuff in a separate PR?

@lgarron
Copy link
Member Author

lgarron commented Sep 12, 2023

Can we do one thing at a time? That is, can we do the biomejs stuff in a separate PR?

I don't feel comfortable introducing a new JS file without biome, but if you really want I could probably take it out.

@jfly
Copy link
Member

jfly commented Sep 12, 2023

I don't feel comfortable introducing a new JS file without biome

Could we add biomejs first, then?

@lgarron
Copy link
Member Author

lgarron commented Sep 12, 2023

I don't feel comfortable introducing a new JS file without biome

Could we add biomejs first, then?

Not without applying it to the existing build script, which I'm not enthused about? But you seem to feel strongly about this, lemme find a way.

@lgarron
Copy link
Member Author

lgarron commented Sep 12, 2023

I don't feel comfortable introducing a new JS file without biome

Could we add biomejs first, then?

Not without applying it to the existing build script, which I'm not enthused about? But you seem to feel strongly about this, lemme find a way.

I mean, I guess we could add biome scoped to scripts as a stub. That's a bit silly, but I guess it works.

lgarron added a commit that referenced this pull request Sep 12, 2023
Note that this only covers the `script` directory, as #112 (comment) will remove the old build script.
lgarron added a commit that referenced this pull request Sep 12, 2023
Note that this only covers the `script` directory, as #112 (comment) will remove the old build script.
@lgarron lgarron changed the base branch from lgarron/underscores to main September 12, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants