Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document missing SUMO libraries #6232

Closed
wants to merge 9 commits into from

Conversation

stefaniapedrazzi
Copy link
Member

Address #6217:
document missing system dependencies to run the SUMO exported on Ubuntu 22.04 (and Ubuntu 20.04).

@stefaniapedrazzi stefaniapedrazzi added the bug Something isn't working label Jun 19, 2023
@stefaniapedrazzi stefaniapedrazzi added this to the R2023b milestone Jun 19, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this Jun 19, 2023
@stefaniapedrazzi stefaniapedrazzi linked an issue Jun 19, 2023 that may be closed by this pull request
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review June 19, 2023 15:42
@stefaniapedrazzi stefaniapedrazzi requested a review from a team as a code owner June 19, 2023 15:42
@ygoumaz ygoumaz requested review from omichel and ygoumaz and removed request for omichel June 20, 2023 08:29
@BenjaminDeleze
Copy link

I just finished to test it with the .deb on a fresh Ubuntu 22 VM and I had no need to install other dependencies, neither to use the OSM importer nor to run the world with SUMO afterward.
Could it be that the issue arise only with snap?

@stefaniapedrazzi
Copy link
Member Author

No, I have the exact same issue with the tarball.

@stefaniapedrazzi
Copy link
Member Author

It works with the debian package because the package already depends libgdal-dev and libfox-1.6-dev

@BenjaminDeleze
Copy link

Did you follow the installation instruction for the .tar.gz?
https://cyberbotics.com/doc/guide/installation-procedure?version=master&tab-os=linux#installing-the-tarball-package
Because it is specified that you need some additional packages for SUMO.

@stefaniapedrazzi
Copy link
Member Author

No I didn't. But the same issue occurs with the snap package, and I had in any case to install these two additional libraries to make it work.
Moreover, I didn't need to install the dev packages. So probably also the installation documentation needs to be reviewed.

@stefaniapedrazzi
Copy link
Member Author

stefaniapedrazzi commented Jun 21, 2023

I will test it, but also for the debian package I don't think we need to depend on the dev packages.

@ygoumaz
Copy link
Contributor

ygoumaz commented Jun 21, 2023

There is also a lot of libraries missing on macOS preventing the use of SUMO. After discussion with @BenjaminDeleze, I wonder here what our best option is. By embedding it in the Webots distribution, the goal is to make it work out-of-the-box, so adding documentation (for additional library installation) to make it work doesn't seem to meet the original goal. So here I believe we have two main possibilities:

  • We keep SUMO in the package, but this means that we need to provide all necessary libraries to execute it. When we create the SUMO tar.gz, we follow the following procedure: https://github.com/cyberbotics/webots/wiki/SUMO-compilation where we already add some libraries. We should enhance this procedure with currently missing libraries. The consequence would be that SUMO would work out-of-the-box, but the package might significantly grow in size.
  • We remove completely SUMO of the package and document its installation (which is very fast using apt). SumoInterface and other components that we distribute should probably be adapted. The pros is that the package size will be significantly reduced. The drawback is that the user needs to install SUMO by himself, but it would probably be equivalent to the instructions given in this PR.

@@ -193,7 +193,7 @@ def create_debian_bundle(self):
"libglib2.0-0 (>= 2.10.0), libegl1, libglu1-mesa | libglu1, libgtk-3-0, "
"libnss3, libstdc++6 (>= 4.0.2-4), libxaw7, libxrandr2, libxrender1, "
"libssh-dev, libzip-dev, xserver-xorg-core, libxslt1.1, "
"libxerces-c-dev, libfox-1.6-dev, libgdal-dev, libproj-dev, libgl2ps-dev, " # SUMO dependencies
"libxerces-c3.2, libfox-1.6-0, libgdal-dev, libproj-dev, libgl2ps1.4, " # SUMO dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept libgdal-devand libproj-dev just because the version changed in Ubuntu 22.04 and this way the version is managed automatically by the packaging tool.

@stefaniapedrazzi
Copy link
Member Author

stefaniapedrazzi commented Jun 21, 2023

As already mentioned in the issue description (#6217) on Ubuntu 22.04 31 libraries are missing, that is 72.9 MB.

@omichel
Copy link
Member

omichel commented Jun 21, 2023

I believe we should completely drop SUMO from the package and provide installation instructions instead.

@stefaniapedrazzi
Copy link
Member Author

I can update the instructions for Linux and remove SUMO from the packages.

@stefaniapedrazzi stefaniapedrazzi deleted the fix-linux-sumo-dependencies branch June 21, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Missing dependencies for SUMO exporter
4 participants