[external-assets] Remove existence checks from AssetGraph #20118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smackesey
force-pushed
the
sean/external-assets-rm-asset-graph-existence-checks
branch
2 times, most recently
from
83c7c4f to
aa004b0
Compare
This was referenced Feb 28, 2024
smackesey
force-pushed
the
sean/external-assets-rm-asset-graph-existence-checks
branch
from
aa004b0 to
3f4d11e
Compare
This was referenced Feb 28, 2024
smackesey
force-pushed
the
sean/external-assets-rm-asset-graph-existence-checks
branch
from
3f4d11e to
da6a579
Compare
smackesey
changed the base branch from
master
to
sean/fix-description-copy-for-graph-multi-asset
smackesey
force-pushed
the
sean/external-assets-rm-asset-graph-existence-checks
branch
from
da6a579 to
67edcc8
Compare
Base automatically changed from
sean/fix-description-copy-for-graph-multi-asset
to
master
March 1, 2024 18:11
smackesey
force-pushed
the
sean/external-assets-rm-asset-graph-existence-checks
branch
from
67edcc8 to
ca47602
Compare
OwenKephart
approved these changes
Mar 1, 2024
smackesey
deleted the
sean/external-assets-rm-asset-graph-existence-checks
branch
This was referenced Mar 3, 2024
[external-assets] Mark public RepositoryDefinition.{assets_defs_by_key, source_assets_by_key}
#20221
Merged
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Remove a few lingering existence checks for assets when accessing properties from the asset graph. These can be removed because callsites have been modified to perform existence checks now. ## How I Tested These Changes Existing test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Remove a few lingering existence checks for assets when accessing properties from the asset graph. These can be removed because callsites have been modified to perform existence checks now.
How I Tested These Changes
Existing test suite