-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[external-assets] Standardize terminology on "execution set" #20140
Conversation
b052dac
to
59f3d5f
Compare
ac8a9c6
to
7228a63
Compare
59f3d5f
to
1fd1ee8
Compare
7228a63
to
2c4a5a8
Compare
1fd1ee8
to
b6ea604
Compare
2c4a5a8
to
0625561
Compare
b6ea604
to
37757be
Compare
101a9c6
to
599d04b
Compare
37757be
to
9224109
Compare
599d04b
to
311d0ef
Compare
9224109
to
1d2272a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
certainly an improvement 🙏
311d0ef
to
3bb4896
Compare
1d2272a
to
5f73c57
Compare
3bb4896
to
d73e923
Compare
5f73c57
to
6ad7465
Compare
Sounds accurate to me |
98c621b
to
edfd67f
Compare
be91c37
to
6a92e61
Compare
edfd67f
to
d455262
Compare
6a92e61
to
c1ecf7a
Compare
d455262
to
5a2551a
Compare
c1ecf7a
to
41726eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per zoom convo:
execution unit -> execution set (the set of asset or check sets executed together)
atomic execution id -> execution set identifier
cc: @OwenKephart for your thoughts on this naming proposal |
5a2551a
to
6eadaed
Compare
41726eb
to
018ca84
Compare
f99d94b
to
76f039d
Compare
I've performed the rename to "execution_set_identifier" |
76f039d
to
8fae51a
Compare
@schrockn @smackesey to be honest, I'm not seeing a major difference between "execution unit" and "execution set" -- fine with this outcome. |
8fae51a
to
6cab24d
Compare
@OwenKephart the thinking is that the word "set" indicates the "set of keys in an asset graph that must be executed together". This aligns with the |
@schrockn anything else you wanted to see in this PR |
## Summary & Motivation The terminology around groups of assets/checks that must be executed together is currently a little mixed: - `AssetGraph` has `get_required_multi_asset_keys` and `get_required_asset_and_check_keys` - `ExternalAssetNode` and `ExternalAssetCheck` have a field `atomic_execution_unit_id` It's not obvious that these are related to one another. This PR attempts to tighten up and standardize the terminology around the phrase "execution set": - `AssetGraph.get_required_multi_asset_keys` -> `get_execution_set_asset_keys` - `AssetGraph.get_required_asset_and_check_keys` -> `get_execution_set_asset_and_check_keys` - `ExternalAsset{Node,Check}.atomic_execution_unit_id` -> `execution_set_id` It also tweaks the return value of the `AssetGraph` functions-- the current behavior is to return an empty set for subsettable assets, which does not make sense for "execution sets"-- this changes it to return a set with a single element (the passed asset key). ## How I Tested These Changes Existing test suite.
Summary & Motivation
The terminology around groups of assets/checks that must be executed together is currently a little mixed:
AssetGraph
hasget_required_multi_asset_keys
andget_required_asset_and_check_keys
ExternalAssetNode
andExternalAssetCheck
have a fieldatomic_execution_unit_id
It's not obvious that these are related to one another. This PR attempts to tighten up and standardize the terminology around the phrase "execution set":
AssetGraph.get_required_multi_asset_keys
->get_execution_set_asset_keys
AssetGraph.get_required_asset_and_check_keys
->get_execution_set_asset_and_check_keys
ExternalAsset{Node,Check}.atomic_execution_unit_id
->execution_set_id
It also tweaks the return value of the
AssetGraph
functions-- the current behavior is to return an empty set for subsettable assets, which does not make sense for "execution sets"-- this changes it to return a set with a single element (the passed asset key).How I Tested These Changes
Existing test suite.