[external-assets] Update AssetGraph accessor callsites to fetch nodes #20132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @smackesey and the rest of your teammates on |
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
from
ff8d5c8 to
f29fe01
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
4a29f71 to
da302fa
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
from
f29fe01 to
dfc5cb1
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
da302fa to
19d2ba5
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
from
dfc5cb1 to
d7f3f4b
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
19d2ba5 to
0f1c2e7
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
from
d7f3f4b to
0529c67
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
3 times, most recently
from
cf187b8 to
dc8fb63
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
6 times, most recently
from
1fcdd2d to
bac78b2
Compare
This was referenced Mar 1, 2024
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
2 times, most recently
from
8d7d177 to
f211e23
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
0f1c2e7 to
991eef7
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
2 times, most recently
from
3ad746c to
4144704
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
991eef7 to
fb44397
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
d5de819 to
83293c9
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
from
41f6169 to
a8b3346
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
83293c9 to
6596798
Compare
This was referenced Mar 5, 2024
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
5 times, most recently
from
580f7fe to
b03c797
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
6596798 to
715992d
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
from
b03c797 to
b3ba639
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
715992d to
620d0c2
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
from
b3ba639 to
d58d492
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
620d0c2 to
c1ee471
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
c1ee471 to
d8f94a8
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
from
d58d492 to
3a653f2
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
d8f94a8 to
c7142ad
Compare
smackesey
force-pushed
the
sean/external-assets-asset-graph-nodes
branch
2 times, most recently
from
f60e7cb to
cbccceb
Compare
Base automatically changed from
sean/external-assets-asset-graph-nodes
to
master
March 7, 2024 14:48
[INTERNAL_BRANCH=sean/external-assets-asset-graph-nodes]
smackesey
force-pushed
the
sean/external-assets-asset-graph-callsites
branch
from
c7142ad to
94186ae
Compare
This was referenced Mar 7, 2024
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
…#20132) ## Summary & Motivation Internal companion PR: dagster-io/internal#8462 Part 2 of `AssetGraph` node implementation. Here we remove the old property accessor methods on `AssetGraph` and change the callsites to access nodes and call the accessor on the node objects instead. ## How I Tested These Changes Existing test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Internal companion PR: https://github.com/dagster-io/internal/pull/8462
Part 2 of
AssetGraphnode implementation. Here we remove the old property accessor methods onAssetGraphand change the callsites to access nodes and call the accessor on the node objects instead.How I Tested These Changes
Existing test suite.