Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[external-rename] host_representation -> remote_representation #20323

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

smackesey
Copy link
Collaborator

@smackesey smackesey commented Mar 7, 2024

Summary & Motivation

Internal companion PR: https://github.com/dagster-io/internal/pull/8610

Rename dagster._core.host_represenation -> remote_representation.

How I Tested These Changes

Existing test suite.

@smackesey smackesey force-pushed the sean/host-representation-remote-representation branch from 60bd233 to deb9ef8 Compare March 7, 2024 12:44
@smackesey smackesey force-pushed the sean/external-assets-asset-graph-callsites branch from c1ee471 to d8f94a8 Compare March 7, 2024 13:10
@smackesey smackesey force-pushed the sean/host-representation-remote-representation branch from deb9ef8 to 49349a3 Compare March 7, 2024 13:10
@smackesey smackesey force-pushed the sean/external-assets-asset-graph-callsites branch 2 times, most recently from c7142ad to 94186ae Compare March 7, 2024 14:50
@smackesey smackesey force-pushed the sean/host-representation-remote-representation branch from 49349a3 to e37d122 Compare March 7, 2024 14:50
@smackesey smackesey marked this pull request as ready for review March 7, 2024 14:52
@smackesey smackesey requested a review from schrockn March 7, 2024 14:52
Base automatically changed from sean/external-assets-asset-graph-callsites to master March 7, 2024 15:26
@smackesey smackesey force-pushed the sean/host-representation-remote-representation branch 2 times, most recently from 790a1ba to 468a975 Compare March 7, 2024 15:53
@smackesey smackesey force-pushed the sean/host-representation-remote-representation branch from 468a975 to 866ffd8 Compare March 7, 2024 16:42
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didntreadlol

[INTERNAL_BRANCH=sean/host-repreentation-remote-representation]
@smackesey smackesey force-pushed the sean/host-representation-remote-representation branch from 866ffd8 to 7f9a5c6 Compare March 8, 2024 13:02
@smackesey smackesey merged commit e3381e2 into master Mar 8, 2024
1 check passed
@smackesey smackesey deleted the sean/host-representation-remote-representation branch March 8, 2024 14:03
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
## Summary & Motivation

Internal companion PR: dagster-io/internal#8610

Rename `dagster._core.host_represenation` -> `remote_representation`.

## How I Tested These Changes

Existing test suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants