Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_list typed #22399

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Make is_list typed #22399

merged 1 commit into from
Jun 12, 2024

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Jun 9, 2024

Summary & Motivation

I made is_list type-narrowing to assist with some debugging and figured it would be useful to check in. Also found some obvious errors which I type ignored.

How I Tested These Changes

BK

Copy link
Member Author

schrockn commented Jun 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @schrockn and the rest of your teammates on Graphite Graphite

@schrockn schrockn force-pushed the type-test-asset-check-decorator branch from d7b5a78 to 8e2c6aa Compare June 9, 2024 17:14
@schrockn schrockn force-pushed the type-test-asset-check-decorator branch from 8e2c6aa to a9ff512 Compare June 9, 2024 17:15
@schrockn schrockn requested review from smackesey and sryza June 9, 2024 18:22
@schrockn schrockn marked this pull request as ready for review June 9, 2024 18:22
@schrockn schrockn force-pushed the type-test-asset-check-decorator branch from a9ff512 to e18f92f Compare June 10, 2024 12:08
Copy link
Member Author

schrockn commented Jun 12, 2024

Merge activity

  • Jun 12, 10:06 AM EDT: @schrockn started a stack merge that includes this pull request via Graphite.
  • Jun 12, 10:12 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 12, 10:13 AM EDT: @schrockn merged this pull request with Graphite.

@schrockn schrockn force-pushed the type-test-asset-check-decorator branch from 5377ca1 to ac2f04d Compare June 12, 2024 14:09
Base automatically changed from type-test-asset-check-decorator to master June 12, 2024 14:11
@schrockn schrockn merged commit 30dee7e into master Jun 12, 2024
1 check was pending
@schrockn schrockn deleted the typed-is-list branch June 12, 2024 14:13
cmpadden pushed a commit that referenced this pull request Jun 13, 2024
## Summary & Motivation

I made `is_list` type-narrowing to assist with some debugging and figured it would be useful to check in. Also found some obvious errors which I type ignored.

## How I Tested These Changes

BK
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary & Motivation

I made `is_list` type-narrowing to assist with some debugging and figured it would be useful to check in. Also found some obvious errors which I type ignored.

## How I Tested These Changes

BK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants