Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pool tag to display for ops / assets #26804

Open
wants to merge 1 commit into
base: prha/distinguish_unconfigured_from_zero_slots
Choose a base branch
from
Open

add pool tag to display for ops / assets #26804

wants to merge 1 commit into from

Conversation

prha
Copy link
Member

@prha prha commented Jan 3, 2025 •
edited
Loading

Summary & Motivation

Adds a new PoolTag component, that is used for op / asset definition info pages to show pool concurrency status.

Screen.Recording.2025-01-09.at.5.16.20.PM.mov

How I Tested These Changes

BK, inspection

Changelog

Adds pool information in the UI for asset / op definitions that use concurrency pools.

This was referenced Jan 3, 2025
Open
Open
@prha Graphite App
Copy link
Member Author

prha commented Jan 3, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 3, 2025
Draft
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-kt6sm4r8e-elementl.vercel.app
https://prha-ui-pool-reference.core-storybook.dagster-docs.io

Built with commit 39f76f5.
This pull request is being automatically deployed with vercel-action

@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from b677ae4 to ba46ced Compare January 6, 2025 20:04
@prha prha force-pushed the prha/ui_pool_reference branch from 18c1cfc to c01da8d Compare January 6, 2025 20:04
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from ba46ced to 3c0b564 Compare January 6, 2025 20:52
@prha prha force-pushed the prha/ui_pool_reference branch from c01da8d to 15bc61b Compare January 6, 2025 20:52
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 3c0b564 to 365053a Compare January 6, 2025 22:06
@prha prha force-pushed the prha/ui_pool_reference branch from 15bc61b to 81fd01b Compare January 6, 2025 22:06
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 365053a to d10b8c0 Compare January 7, 2025 17:16
@prha prha force-pushed the prha/ui_pool_reference branch from 81fd01b to 948ce8f Compare January 7, 2025 17:17
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from d10b8c0 to 05fe5ce Compare January 7, 2025 18:54
@prha prha force-pushed the prha/ui_pool_reference branch from 948ce8f to e95b257 Compare January 7, 2025 18:54
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 05fe5ce to e1241a5 Compare January 7, 2025 22:53
@prha prha force-pushed the prha/ui_pool_reference branch from e95b257 to 02311b6 Compare January 7, 2025 22:53
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from e1241a5 to 4b189fe Compare January 8, 2025 04:25
@prha prha force-pushed the prha/ui_pool_reference branch from 02311b6 to fd552b6 Compare January 8, 2025 04:25
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 4b189fe to 68a6334 Compare January 8, 2025 04:49
@prha prha force-pushed the prha/ui_pool_reference branch 2 times, most recently from f1ee75f to 3c5deda Compare January 8, 2025 05:13
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 68a6334 to 103ad25 Compare January 8, 2025 05:17
@prha prha force-pushed the prha/ui_pool_reference branch from 3c5deda to 9fa4539 Compare January 8, 2025 05:17
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 103ad25 to b5f30e6 Compare January 8, 2025 19:52
@prha prha force-pushed the prha/ui_pool_reference branch from 9fa4539 to 16f3f44 Compare January 8, 2025 19:52
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from b5f30e6 to 376b5b9 Compare January 8, 2025 20:36
@prha prha force-pushed the prha/ui_pool_reference branch from 16f3f44 to dc05156 Compare January 8, 2025 20:36
@prha prha mentioned this pull request Jan 9, 2025
Open
This was referenced Jan 9, 2025
Open
Open
@prha prha changed the title UI references to concurrency group add pool tag to display for ops / assets Jan 9, 2025
@prha prha marked this pull request as ready for review January 9, 2025 04:13
@prha prha requested review from bengotow and hellendag January 9, 2025 04:13
hellendag
hellendag reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@hellendag hellendag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a screenshot of what it looks like?

js_modules/dagster-ui/packages/ui-core/src/assets/AssetSidebarActivitySummary.tsx Outdated Show resolved Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/overview/ComputeDetailsSection.tsx
<PoolTag key={idx} pool={pool} />
))}
</Box>
) : null}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be any kind of content for the 0 case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe None or something? Or not show the section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the AttributeAndValue already does this (hides the section)?

js_modules/dagster-ui/packages/ui-core/src/pipelines/SidebarOp.tsx Outdated Show resolved Hide resolved
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 236d086 to b4aa185 Compare January 10, 2025 01:17
@prha prha force-pushed the prha/ui_pool_reference branch from 2d2cbff to 8e5792c Compare January 10, 2025 01:17
@prha prha requested a review from hellendag January 10, 2025 21:33
hellendag
hellendag approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@hellendag hellendag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions, but otherwise lgtm.

js_modules/dagster-ui/packages/ui-core/src/assets/overview/ComputeDetailsSection.tsx
<PoolTag key={idx} pool={pool} />
))}
</Box>
) : null}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe None or something? Or not show the section?

js_modules/dagster-ui/packages/ui-core/src/instance/PoolTag.tsx
placement="top"
content="This pool currently does not have any slots configured."
>
<Icon name="check_warning" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • How about warning_outline? The contrast of the black icon is maybe a little jarring.
  • Should the Tag be intent="warning" or something in the warning case?

@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from b4aa185 to 8961b32 Compare January 10, 2025 23:23
@prha prha force-pushed the prha/ui_pool_reference branch from 8e5792c to 9eacecf Compare January 10, 2025 23:23
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 8961b32 to 2a97398 Compare January 16, 2025 00:02
@prha prha force-pushed the prha/ui_pool_reference branch from 9eacecf to 32acc8e Compare January 16, 2025 00:02
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 2a97398 to 530d3f7 Compare January 16, 2025 00:19
@prha prha force-pushed the prha/ui_pool_reference branch from 32acc8e to 0c9846b Compare January 16, 2025 00:19
@prha prha mentioned this pull request Jan 16, 2025
Open
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 530d3f7 to dc2e6c0 Compare January 16, 2025 20:22
@prha prha force-pushed the prha/ui_pool_reference branch from 0c9846b to 47abf33 Compare January 16, 2025 20:22
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from dc2e6c0 to 108b5e0 Compare January 17, 2025 01:07
@prha prha force-pushed the prha/ui_pool_reference branch from 47abf33 to d7bb131 Compare January 17, 2025 01:07
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 108b5e0 to 1d00bac Compare January 17, 2025 02:27
@prha prha force-pushed the prha/ui_pool_reference branch from d7bb131 to fefe7fa Compare January 17, 2025 02:27
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 1d00bac to bbd55e4 Compare January 17, 2025 02:54
@prha prha force-pushed the prha/ui_pool_reference branch from fefe7fa to fda08ba Compare January 17, 2025 02:54
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from bbd55e4 to 222005b Compare January 17, 2025 22:30
@prha prha force-pushed the prha/ui_pool_reference branch from fda08ba to 39f76f5 Compare January 17, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellendag hellendag hellendag approved these changes

@bengotow bengotow bengotow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prha @bengotow @hellendag