Update docs to reflect pools concept for concurrency #27171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit aa5ef8c. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-hge1uecii-elementl.vercel.app Direct link to changed pages: |
prha
force-pushed
the
prha/run_pools_ui
branch
from
840e884 to
558acb1
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
aa5ef8c to
c15ed10
Compare
prha
changed the title
prha
force-pushed
the
prha/concurrency_docs
branch
from
c15ed10 to
45ed699
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
558acb1 to
a169ead
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
45ed699 to
520a23a
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
a169ead to
9db7df6
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
520a23a to
8b6dbf2
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
9db7df6 to
3fdabb4
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
8b6dbf2 to
895f9e5
Compare
## Summary & Motivation Users often want to make small changes to the existing policies. There is an existing utility to remove a sub-condition (`.without(…)`), and you can add a new sub-condition with `&`. However, these utilities aren't always the most ergonomic for certain use cases. This would allow the following types of changes to our examples: [Older time window partitions](https://docs.dagster.io/concepts/automation/declarative-automation/customizing-automation-conditions#update-an-older-time-partition-when-using-automationconditionon_cron) before: ```python condition = five_days_ago_condition & AutomationCondition.eager().without( AutomationCondition.in_latest_time_window(), ) ``` after: ```python AutomationCondition.eager().replace( "in_latest_time_window", five_days_ago_condition ) ``` ## How I Tested These Changes Added unit tests. ## Changelog Implemented `AutomationCondition.replace()` function to improve ergonomics of updating sub-conditions.
prha
force-pushed
the
prha/run_pools_ui
branch
from
3fdabb4 to
ffc15a7
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
895f9e5 to
6e54cc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Changes the docs to include the pools concept
How I Tested These Changes
Inspection