add pool graphql fields for runs #26964
Open
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b58d918. |
prha
force-pushed
the
prha/concurrency_granularity
branch
from
d217d12 to
72da007
Compare
prha
force-pushed
the
prha/run_pools_graphql
branch
from
4dacceb to
a8ac3e7
Compare
prha
force-pushed
the
prha/concurrency_granularity
branch
from
72da007 to
8782d96
Compare
prha
force-pushed
the
prha/run_pools_graphql
branch
from
a8ac3e7 to
3d16333
Compare
prha
force-pushed
the
prha/concurrency_granularity
branch
from
8782d96 to
5c83e2c
Compare
prha
force-pushed
the
prha/run_pools_graphql
branch
from
3d16333 to
a4ee6b4
Compare
prha
force-pushed
the
prha/concurrency_granularity
branch
from
5c83e2c to
9e5e36d
Compare
prha
force-pushed
the
prha/run_pools_graphql
branch
from
a4ee6b4 to
ebd3269
Compare
prha
force-pushed
the
prha/concurrency_granularity
branch
from
9e5e36d to
eb04b1b
Compare
prha
force-pushed
the
prha/run_pools_graphql
branch
from
ebd3269 to
a81756e
Compare
prha
force-pushed
the
prha/concurrency_granularity
branch
from
eb04b1b to
d80e191
Compare
prha
force-pushed
the
prha/run_pools_graphql
branch
from
a81756e to
b202de6
Compare
prha
force-pushed
the
prha/concurrency_granularity
branch
from
d80e191 to
e5ad4c3
Compare
prha
force-pushed
the
prha/run_pools_graphql
branch
from
b202de6 to
46e8b90
Compare
prha
force-pushed
the
prha/concurrency_granularity
branch
from
e5ad4c3 to
111c97c
Compare
prha
force-pushed
the
prha/run_pools_graphql
branch
from
46e8b90 to
591be98
Compare
prha
force-pushed
the
prha/concurrency_granularity
branch
from
111c97c to
4e2eb36
Compare
prha
force-pushed
the
prha/run_pools_graphql
branch
from
591be98 to
1ef1cac
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+626
to
+630
| def resolve_allConcurrencyKeys(self, graphene_info: ResolveInfo): | ||
| if not self.dagster_run.run_op_concurrency: | ||
| return None | ||
|
|
||
| return list(self.dagster_run.run_op_concurrency.all_pools) |
There was a problem hiding this comment.
The schema defines allConcurrencyKeys as a non-null array of strings ([String!]), but this resolver returns None when run_op_concurrency is not present. To maintain type consistency, consider returning an empty list instead:
return [] if not self.dagster_run.run_op_concurrency else list(self.dagster_run.run_op_concurrency.all_pools)Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
OwenKephart
reviewed
Jan 17, 2025
| @@ -389,6 +389,7 @@ class GrapheneRun(graphene.ObjectType): | |||
| hasDeletePermission = graphene.NonNull(graphene.Boolean) | |||
| hasConcurrencyKeySlots = graphene.NonNull(graphene.Boolean) | |||
| rootConcurrencyKeys = graphene.List(graphene.NonNull(graphene.String)) | |||
| allConcurrencyKeys = graphene.List(graphene.NonNull(graphene.String)) | |||
There was a problem hiding this comment.
If this is a net-new field should we just call this allPools from the outset?
prha
force-pushed
the
prha/run_pools_graphql
branch
from
1ef1cac to
b58d918
Compare
prha
changed the base branch from
prha/concurrency_granularity
to
prha/hoist_run_queue_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Makes pool information available for the containing runs, to provide debugging information on the Run view, potentially the Run table.
How I Tested These Changes
BK