Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20861] Implement copy_from_topic_qos method #4719

Merged
merged 12 commits into from
May 7, 2024
Merged

[20861] Implement copy_from_topic_qos method #4719

merged 12 commits into from
May 7, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Apr 23, 2024 •
edited by EduPonz
Loading

Description

This PR

  • Implement the method copy_from_topic_qos().
  • Define the value DATAWRITER_QOS_USE_TOPIC_QOS and DATAREADER_QOS_USE_TOPIC_QOS. These values can be used to indicate that the DataWriter or DataReader should be created with a combination of the default DataWriter QoS and the Topic QoS using copy_from_topic_qos().
  • Add the previous logic to the costructor of DataReaderImpl and DataWriterImpl.
  • Remove copy_from_topic_qos() from UnsupportedPublisherMethods and UnsupportedSubscriberMethods tests.

Related documentation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v2.14.1 milestone Apr 23, 2024
@elianalf elianalf changed the title Implement copy_from_topic_qos method [20861] Implement copy_from_topic_qos method Apr 23, 2024
@elianalf elianalf mentioned this pull request Apr 24, 2024
Merged
7 tasks
EduPonz
EduPonz suggested changes Apr 25, 2024
View reviewed changes
include/fastdds/dds/subscriber/Subscriber.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/publisher/Publisher.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/SubscriberImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/Subscriber.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/Publisher.cpp Outdated Show resolved Hide resolved
test/unittest/dds/publisher/PublisherTests.cpp Show resolved Hide resolved
test/unittest/dds/subscriber/SubscriberTests.cpp Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/DataReaderImpl.cpp Outdated Show resolved Hide resolved
@elianalf elianalf force-pushed the feature/copy_from_topic_qos branch from fe98236 to 145ef71 Compare April 29, 2024 14:28
EduPonz
EduPonz suggested changes Apr 29, 2024
View reviewed changes
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/DataReaderImpl.cpp Show resolved Hide resolved
elianalf and others added 11 commits April 30, 2024 12:59
@elianalf @EduPonz
Refs #20861: Implementation of copy_from_topic_qos in SubscriberImp a…
4b88bf2 
…nd PublisherImpl

Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Refs #20861: Add call_from_topic_qos in Publisher and Subscriber
d764d7c 
Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Refs #20861: Remove copy_from_topic_qos from test unsupported methods
0a91d9d 
Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Refs #20861: Add DATAWRITER_QOS_USE_TOPIC_QOS to create a datawriter …
e386bc4 
…getting topic qos

Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Refs #20861: Add DATAREADER_QOS_USE_TOPIC_QOS to create a datareader …
67ce862 
…getting topic qos

Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Refs #20861: Add unittest
b18e8a5 
Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Refs #20861: Add blackbox test
2893123 
Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Refs #20861: Apply suggestions
7612b43 
Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Refs #20861: Uncrustify
e227ade 
Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Refs #20861: Add missing qos and set as default qos
431a8c3 
Signed-off-by: elianalf <[email protected]>
@EduPonz
Refs #20861: Apply Edu's suggestions
9365c8f 
Signed-off-by: eduponz <[email protected]>
@EduPonz EduPonz force-pushed the feature/copy_from_topic_qos branch from 145ef71 to 9365c8f Compare April 30, 2024 11:01
@EduPonz EduPonz self-requested a review April 30, 2024 11:02
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 30, 2024
@elianalf elianalf force-pushed the feature/copy_from_topic_qos branch from 8ed0298 to c9e44a0 Compare May 3, 2024 08:18
@elianalf elianalf requested review from EduPonz and removed request for EduPonz May 3, 2024 08:18
@elianalf elianalf force-pushed the feature/copy_from_topic_qos branch from c9e44a0 to 9f8ebb2 Compare May 3, 2024 08:21
@elianalf elianalf force-pushed the feature/copy_from_topic_qos branch from 9f8ebb2 to 9bc9a55 Compare May 3, 2024 08:43
@elianalf elianalf requested review from EduPonz and removed request for EduPonz May 3, 2024 08:44
@elianalf
Copy link
Contributor Author

elianalf commented May 3, 2024

@richiprosima please test this

@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 7, 2024
@EduPonz EduPonz merged commit c2a4523 into master May 7, 2024
11 of 17 checks passed
@EduPonz EduPonz deleted the feature/copy_from_topic_qos branch May 7, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@elianalf @EduPonz