terraform: enable build tag #13841
Merged
terraform: enable build tag #13841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @v1v? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
v1v
changed the title
reakaleek
approved these changes
Aug 7, 2024
endorama
approved these changes
Aug 7, 2024
kruskall
approved these changes
Aug 7, 2024
Closed
|
@Mergifyio backport 8.15 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
(cherry picked from commit b4c79b3) # Conflicts: # testing/infra/terraform/modules/tags/output.tf
2 tasks
v1v
added
backport-8.15
mergify
bot
removed
backport-skip
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
(cherry picked from commit b4c79b3) # Conflicts: # testing/infra/terraform/modules/tags/output.tf
2 tasks
|
|
mergify
bot
added
the
backport-8.x
mergify bot
added a commit
that referenced
this pull request
Oct 3, 2024
* terraform: enable build tag (#13841) (cherry picked from commit b4c79b3) # Conflicts: # testing/infra/terraform/modules/tags/output.tf * Update testing/infra/terraform/modules/tags/output.tf --------- Co-authored-by: Victor Martinez <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
I'd like to honour the CI details so we can tag any cloud resources with the Build ID or so, this will help to identify if the resources were created when running the terraform locally or in the CI.
For instance, currently
Then when https://github.com/elastic/apm-aws-lambda/actions/workflows/smoke-tests.yml runs I wanna see
Or something similar
Checklist
For functional changes, consider:
How to test these changes
Related issues