Gnome 45 compatibility #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "legacy" branch seems a reasonable accommodation for anyone not yet using gnome 45 - we should probably update the README to make it clear though. There are a couple other updates needed there for similar reasons, i.e. #202, so we could leave that for a later documentation-focused update instead. I'll review and test this in a bit more detail at some point this/next week, but having had a brief look at the changes they seem good/reasonable! |
derenv
added
enhancement
needs review
|
yeah good point, the readme is a bit dated. I opened PR #214 to address these issues, it might need to be rebased before merging. |
derenv
reviewed
Feb 21, 2024
derenv
added
needs testing
derenv
approved these changes
Mar 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes to imports required for Gnome 45. Since it breaks backwards compatibility, I created a new "legacy" branch from master before this PR that contains the old code compatible with versions 40-44.
I tried to keep the changes minimal, but it was still necessary to change every JS file, since all imports had to be updated.
This addresses issue #212.