Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snfoundry.toml generation logic and docs #2467

Merged
merged 28 commits into from
Sep 20, 2024
Merged

Add snfoundry.toml generation logic and docs #2467

merged 28 commits into from
Sep 20, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Sep 12, 2024 •
edited
Loading

Closes #1802

Introduced changes

  • Added snfoundry.toml Format section to docs
  • Added logic that generate snfoundry.toml in new project

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula marked this pull request as draft September 12, 2024 13:09
@kkawula kkawula marked this pull request as ready for review September 16, 2024 09:57
@kkawula kkawula marked this pull request as draft September 16, 2024 10:56
integraledelebesgue
integraledelebesgue reviewed Sep 17, 2024
View reviewed changes
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
@kkawula kkawula changed the title Add snfoundry.toml Format section to docs Add snfoundry.toml generation logic and docs Sep 17, 2024
@kkawula kkawula marked this pull request as ready for review September 17, 2024 12:56
cptartur
cptartur requested changes Sep 18, 2024
View reviewed changes
crates/forge/src/init.rs Outdated Show resolved Hide resolved
crates/forge/src/init.rs Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
@cptartur cptartur mentioned this pull request Sep 19, 2024
Open
cptartur
cptartur reviewed Sep 19, 2024
View reviewed changes
crates/forge/src/init.rs Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/snfoundry-toml.md Outdated Show resolved Hide resolved
integraledelebesgue
integraledelebesgue approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@integraledelebesgue integraledelebesgue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkawula kkawula added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit 627a4ac Sep 20, 2024
23 checks passed
@kkawula kkawula deleted the kkawula/1802-snfoundry-toml-docs branch September 20, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@ksew1 ksew1 Awaiting requested review from ksew1

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add snfoundry.toml Reference/Format section to docs
3 participants
@kkawula @cptartur @integraledelebesgue