-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
155 add serotypefinder module #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with extremely minor notes!
I'm not super up to speed with Nextflow yet though, so have mostly checked for obvious stuff, and some extra carefully in the Makefile etc.
@@ -108,13 +112,13 @@ process { | |||
container = "${params.containerDir}/bwakit.sif" | |||
cpus = 16 | |||
memory = '20 GB' | |||
publishDir = [ path: "${params.outdir}/${params.speciesDir}/bwa", mode: 'copy', overwrite: true ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what happened here... Guess it is legit, but so the publishdir was just moved (same for the other files)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was publishing the wrong bam file. bwa
is run on it's own assembly for qc purposes as well as against a reference genome to check variants
Description
Summary of the changes made:
Primary function of PR
Testing
Tested in conjunction with unreleased bonsai-prp version (currently being reviewed)