Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

155 add serotypefinder module #268

Merged
merged 18 commits into from
Feb 23, 2024
Merged

Conversation

ryanjameskennedy
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy commented Feb 16, 2024

Description

Summary of the changes made:

  • Added serotypefinder
  • Add --organism flag to amrfinder

Primary function of PR

  • Major functionality improvement / New type of analysis

Testing

Tested in conjunction with unreleased bonsai-prp version (currently being reviewed)

Copy link
Contributor

@samuell samuell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with extremely minor notes!

I'm not super up to speed with Nextflow yet though, so have mostly checked for obvious stuff, and some extra carefully in the Makefile etc.

@@ -108,13 +112,13 @@ process {
container = "${params.containerDir}/bwakit.sif"
cpus = 16
memory = '20 GB'
publishDir = [ path: "${params.outdir}/${params.speciesDir}/bwa", mode: 'copy', overwrite: true ]
Copy link
Contributor

@samuell samuell Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened here... Guess it is legit, but so the publishdir was just moved (same for the other files)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was publishing the wrong bam file. bwa is run on it's own assembly for qc purposes as well as against a reference genome to check variants

@ryanjameskennedy ryanjameskennedy merged commit 7b1f8f9 into master Feb 23, 2024
3 checks passed
@ryanjameskennedy ryanjameskennedy deleted the 155-add-serotypefinder-module branch February 23, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants