Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GUI to accomodate data updates #151

Merged

Conversation

brianlove
Copy link
Contributor

Update the GUI to take into account updates to the data schema.

Changes to the group selection interface will come in a later PR.

Update the GUI to take into account updates to the data schema.
Changes to the group selection interface will come in a later PR.
@brianlove brianlove requested a review from jmelot October 18, 2023 19:43
@brianlove brianlove self-assigned this Oct 18, 2023
@github-actions
Copy link

github-actions bot commented Oct 18, 2023

No need for rebasing 👍
behind_count is 0
ahead_count is 3

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 62%
62.17% (286/460) 57.64% (98/170) 63.97% (103/161)
Modified Files • (62%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files62.1757.6463.9762.47 
components60.6159.8660.4660.85 
   DetailView.jsx000029–144
   DetailViewIntro.jsx000013–106
   DetailViewMoreMetadataDialog.jsx00009–93
   DetailViewPatents.jsx01000016–138
   DetailViewPublications.jsx01000017–143
   DetailViewWorkforce.jsx00009–22
   StatBox.jsx0100008–61
static_data94.7310010094.73 
   table_columns.js100100100100 

@brianlove brianlove mentioned this pull request Oct 18, 2023
Increase test timeout to hopefully resolve issue where
`waitForElementToBeRemoved` times out:
testing-library/dom-testing-library#1204
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jmelot jmelot merged commit 397e40e into 138-134-18-data-structure-updates Oct 20, 2023
1 check passed
@jmelot jmelot deleted the gui-updates-following-data-updates branch October 20, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants