Fix Rails 6.1 deprecation warnings #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sort of deprecation warning was being printed:
DEPRECATION WARNING: Calling `<<` to an ActiveModel::Errors message
array in order to add an error is deprecated. Please call
`ActiveModel::Errors#add` instead. (called from fact_has_stats at
/Users/pat/projects/guesstimate-server/app/models/fact.rb:70)
This prevents the following deprecation warning:
Sending mail with DeliveryJob and Parameterized::DeliveryJob is
deprecated and will be removed in Rails 6.2. Please use
MailDeliveryJob instead.
quinn-dougherty
temporarily deployed
to
guesstimate-fix-rails-6-s7k7ql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits aren't necessary to upgrade to Rails 6.1, so they can be merged independly of the upgrade. This would make a rollback slightly less messy, and it reduces the risk of incidental breakage.