Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Sort variables ascending by key at serialization time #18051

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

philrenaud
Copy link
Contributor

Doesn't impact the variable view page, as it's already using a table that sorts ascending on key by default, but on the edit page, which iterates over and creates a form label for each, they'll now appear ascending on key alpha.

Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistency is .key

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Ember Test Audit comparison

main 67e5b08 change
passes 1498 1498 0
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.6.x backport to 1.6.x release line
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants