-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set version 0.3.3 && update third-party packages versions && downgrade msys2 && compatibility with now openfhe-development #52
Conversation
As you can observe, now our CI on MacOs fails. In the update of openfhe-development in So what we can do is:
|
Thanks for the detailed analysis. What I don't understand though is why you think it's an issue with CxxWrap.jl - to me it seems to be the combination of a newer clang version with OpenFHE. What about trying to silence the warning for now on macOS by passing |
No, it is of course not an issue with Cxxwrap.jl, but theoretically non-virtual destructor in virtual class is not an error, if no one tries to deallocate the derived class object by the pointer to the virtual class, so there is should be way to wrap normally... I deleted -Werror and it works, but yes, it is better to disable one particular warning, thanks! I disabled the warning and it is compiled successfully! I don't think it is a problem of new version of clang, this warning was added not in clang 15, but before, and we already used in previous commits this clang versions, it was ok, I also tested it in #53. But it is always so difficult with compilers...) Should merge this PR as it is and update Yggdrasil? |
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
I set new version and also update versions of third-party libraries in ci.yml, I forgot to do it last time