Test compilers on MacOs and Windows #53
Conversation
|
Both windows CI using GCC 14.1 failed: https://github.com/hpsc-lab/openfhe-julia/actions/runs/9678185169/job/26701386296?pr=53 So probably problem in compiler, try to fix version of gcc |
|
Opened issue on openfhe-development openfheorg/openfhe-development#822 |
|
Great catch! Is it possible (and feasible) for you to downgrade our CI system to use an older, compatible version of the compilers on macOS/Windows, at least for the time being? |
| @@ -63,7 +63,7 @@ jobs: | |||
| steps: | |||
| - name: Checkout repository | |||
| uses: actions/checkout@v4 | |||
| - uses: msys2/setup-msys2@v2 | |||
| - uses: msys2/setup-msys2@v2.22.0 | |||
There was a problem hiding this comment.
Hi, @sloede,
I try to downgrade setup-msys2 here to get older version of msys2, because it is not possible to choose gcc version within msys2, only by installing older version of msys2 itself. I'm not really good in CI stuff, I used msys2/[email protected], but it still uses newest version of gcc. If you have experience with downgrading GitHub Action version, am I doing it right? If you haven't, do not worry, I will find out this
There was a problem hiding this comment.
using msys2/[email protected] will only change the version of the GitHub action script, i.e., the version of https://github.com/msys2/setup-msys2. What you really want is a specific version of mingw-w64-x86_64-toolchain in line 70 below
There was a problem hiding this comment.
Maybe this is not really possible:
https://stackoverflow.com/a/33986757
msys2/msys2.github.io#205
There was a problem hiding this comment.
older msys2/[email protected] installs older msys2 with older gcc, I recognized, that there is an update: true below, now I was able to install older version of msys with gcc 13.2, should work
There was a problem hiding this comment.
However, if this only affects Windows testing, I'd be ok with accepting a failing windows test, if it only concerns the self-built version of openfhe and not the Yggdrasil-provided ones
There was a problem hiding this comment.
Am I right, that we are not choosing gcc version for Yggdrasil, is it done automatically?
There was a problem hiding this comment.
older msys2/[email protected] installs older msys2 with older gcc, I recognized, that there is an
update: truebelow, now I was able to install older version of msys with gcc 13.2, should work
Wow, this is great! In that case, maybe just do not update for now, but add a TODO comment that we should fix this once OpenFHE 1.2.1 is available and hopefully fixes this issue.
There was a problem hiding this comment.
Am I right, that we are not choosing gcc version for Yggdrasil, is it done automatically?
Yes. I think we specify a rather old version usually to ensure compatibility the greatest possible variety of GCC versions.
There was a problem hiding this comment.
older msys2/[email protected] installs older msys2 with older gcc, I recognized, that there is an
update: truebelow, now I was able to install older version of msys with gcc 13.2, should workWow, this is great! In that case, maybe just do not update for now, but add a TODO comment that we should fix this once OpenFHE 1.2.1 is available and hopefully fixes this issue.
Okay! I'll do!
|
@ArseniyKholod Is this PR still relevant? |
#52 has an unexpected issue with compilation of openfhe-development v1.2.0 on MacOs and Windows, it seems to be a compiler issue. This PR is created only for test, whether older version of openfhe-development gets compilated with GCC v14.1 and Clang 15.0, in all successful PRs before was used older version of GCC v13.2. I want to know it the problem in new openfhe-development version or in new version of gcc