Update manualdrops to allow to specify serum_replicates to exclude #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbloom
requested changes
Sep 11, 2024
There was a problem hiding this comment.
@anloes, the code changes look good, but can you fix the CHANGELOG?
The current version is 3.1.1, and this would make a new change to that, so this should be version 3.1.2. But you added the changes to the CHANGELOG under the existing version 3.1.1.
Also, will we have the same problem with barcode_serum_replicates that you are fixing here for serum_replicates? If so, do you want to add a fix for that now too?
|
Yes, changes completed. Thanks for catching that. |
jbloom
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor bug in manual drops, as described in issue #49 and similar to previously resolved issue #45.