Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide public interface for _convert_node_to_root_polytomy #169

Open
mmore500 opened this issue May 19, 2023 · 1 comment · May be fixed by #194
Open

Provide public interface for _convert_node_to_root_polytomy #169

mmore500 opened this issue May 19, 2023 · 1 comment · May be fixed by #194
Labels
enhancement

Comments

@mmore500
Copy link
Collaborator

This logic is only accessible via "private" i.e., _* access. Should it be made public? Probably.

Outside packages are depending on it (smirarab/sepp#125).
@mmore500 mmore500 mentioned this issue May 19, 2023
Closed
@c5shen c5shen mentioned this issue Jun 21, 2023
Closed
@lrauschning lrauschning mentioned this issue Sep 18, 2023
Merged
@simeonborko simeonborko mentioned this issue Mar 4, 2024
Open
mmore500 added a commit that referenced this issue May 18, 2024
@mmore500
Implement, test polytomize_root
a6025df 
As a public interface for _convert_node_to_root_polytomy

Closes #169
@mmore500 mmore500 linked a pull request May 18, 2024 that will close this issue
Open
@mmore500
Copy link
Collaborator Author

Hi @simeonborko @smirarab --- would this API suit your use case?

https://github.com/jeetsukumaran/DendroPy/pull/194/files#diff-cd53d4c98adf0e3721dbe0f749ecf5dca68face2ed93a651633e079b27e4f43cR2376

@lrauschning lrauschning mentioned this issue Jul 8, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement, test polytomize_root jeetsukumaran/DendroPy
1 participant
@mmore500