Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] API changes considered for v0.1.0 #22

Closed
7 tasks done
josxha opened this issue Sep 16, 2024 · 0 comments · Fixed by #58
Closed
7 tasks done

[FEATURE] API changes considered for v0.1.0 #22

josxha opened this issue Sep 16, 2024 · 0 comments · Fixed by #58
Labels
feature New feature or request
Milestone
v0.1.0

Comments

@josxha
Copy link
Owner

josxha commented Sep 16, 2024 •
edited
Loading

  • use a "Web" prefix for all web-only controls, for example GeolocateControl -> WebGeolocateControl
  • rename web-only MapOptions.controls to MapOptions.webControls
  • remove web-only Marker and addMarker()
  • rename jumpTo() to moveCamera()
  • rename flyTo() to animateCamera()
  • Remove callbacks in favor of the event system
  • Rename all tilt to pitch because this name is used for gl js and native, feat: rename tilt to pinch #45

Note: maplibre native android uses a fix between tilt and pitch.
@josxha josxha converted this from a draft issue Sep 16, 2024
@josxha josxha added this to the v0.1.0 milestone Sep 16, 2024
@josxha josxha added feature New feature or request labels Sep 16, 2024
@josxha josxha changed the title API changes considered for v0.1.0 [FEATURE] API changes considered for v0.1.0 Sep 16, 2024
@gabbopalma gabbopalma mentioned this issue Sep 24, 2024
Merged
3 tasks
josxha added a commit that referenced this issue Sep 24, 2024
@gabbopalma @josxha
feat: rename tilt to pinch (#45)
117c742 
- [X] rename all tilt references to pinch
- [X] update CHANGELOG.md
- [X] update comments for tilt / pinch

Closes a task of #22

---------

Co-authored-by: Joscha <[email protected]>
@josxha josxha moved this from Todo to In Progress in maplibre dev Oct 1, 2024
@josxha josxha linked a pull request Oct 1, 2024 that will close this issue
refactor!: v0.1.0 api changes #58
Merged
5 tasks
@josxha josxha closed this as completed in #58 Oct 1, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in maplibre dev Oct 1, 2024
gabbopalma added a commit to gabbopalma/flutter-maplibre that referenced this issue Nov 10, 2024
@gabbopalma @josxha
feat: rename tilt to pinch (josxha#45)
6fcc076 
- [X] rename all tilt references to pinch
- [X] update CHANGELOG.md
- [X] update comments for tilt / pinch

Closes a task of josxha#22

---------

Co-authored-by: Joscha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
maplibre dev
Status: Done
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

refactor!: v0.1.0 api changes josxha/flutter-maplibre
1 participant
@josxha