Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename tilt to pinch #45

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Conversation

gabbopalma
Copy link
Contributor

  • rename all tilt references to pinch
  • update CHANGELOG.md
  • update comments for tilt / pinch

Closes a task of #22

@josxha josxha modified the milestones: v0.0.2, v0.1.0 Sep 24, 2024
@josxha
Copy link
Owner

josxha commented Sep 24, 2024

Thanks for the pull request @gabbopalma! We can either add it to the breaking v0.1.2 release or by adding deprecations to the public API add it directly to the v0.0.2 feature release. As you wish. 👍
The CI currently fails because one file is not formated. You can fix it by running dart format .

@gabbopalma
Copy link
Contributor Author

gabbopalma commented Sep 24, 2024

I think introducing deprecations in the public API means adding double references to the tilt and pitch properties. This would also mean managing which one to select in their use cases.
Maybe I'm missing some information about deprecations, but these are the ways I've found to manage the properties that are being deprecated (and not the methods, which are easier). Let me know if you have any ideas.
Currently we can stay in v0.1.2 :)

@josxha
Copy link
Owner

josxha commented Sep 24, 2024

After some time thinking about it, I'd love to release it already with the next 0.0.2 release (sorry about the type in my last message, the breaking release will be 0.1.0 😄). Otherwise the newly added max/min tilt parameters would be renamed immediately. And keeping this pull request up-to-date with the main branch could be trickly.
I agree that these deprecations are not that beautiful (and the package probably doesnt' have real users at the moment anyways) but I think it's a nice way to decrease the amount of breaking releases.
But don't worry about the deprecations, I'll add them in. Thanks again for your pull request, your changes look good to me. 👍

@josxha
Copy link
Owner

josxha commented Sep 24, 2024

Alright, should be ready to merge now. Sorry for asking for what you prefer and then not going with it. The pull request came just in the right time.😅

@josxha josxha enabled auto-merge (squash) September 24, 2024 17:22
@josxha josxha enabled auto-merge (squash) September 24, 2024 17:23
@gabbopalma
Copy link
Contributor Author

Don't worry, your choice is definitely good for the purposes of the project. I will see the improvements of the deprecations, I am curious to see what changed ahah.
Well, if that's all, we can close 👍🏼

@josxha josxha merged commit 117c742 into josxha:main Sep 24, 2024
9 checks passed
@josxha josxha added this to the v0.0.2 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants