Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: v0.1.0 api changes #58

Merged
merged 5 commits into from
Oct 1, 2024
Merged

refactor!: v0.1.0 api changes #58

merged 5 commits into from
Oct 1, 2024

Conversation

josxha
Copy link
Owner

@josxha josxha commented Oct 1, 2024

  • use a "Web" prefix for all web-only controls, for example GeolocateControl -> WebGeolocateControl
  • rename web-only MapOptions.controls to MapOptions.webControls
  • rename jumpTo() to moveCamera()
  • rename flyTo() to animateCamera()
  • Remove click callbacks in favor of the event system

@josxha josxha linked an issue Oct 1, 2024 that may be closed by this pull request
7 tasks
Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2024

Deploying flutter-maplibre with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4194c07
Status: ✅  Deploy successful!
Preview URL: https://6b560284.flutter-maplibre.pages.dev
Branch Preview URL: https://refactor-v0-1-0-api-changes.flutter-maplibre.pages.dev

View logs

@josxha josxha marked this pull request as ready for review October 1, 2024 21:08
@josxha josxha added this to the v0.1.0 milestone Oct 1, 2024
@josxha josxha enabled auto-merge (squash) October 1, 2024 21:10
@josxha josxha merged commit 869e994 into main Oct 1, 2024
10 checks passed
@josxha josxha deleted the refactor/v0.1.0-api-changes branch October 1, 2024 21:10
gabbopalma pushed a commit to gabbopalma/flutter-maplibre that referenced this pull request Nov 10, 2024
- [x] use a "Web" prefix for all web-only controls, for example
`GeolocateControl` -> `WebGeolocateControl`
- [x] rename web-only `MapOptions.controls` to `MapOptions.webControls`
- [x] rename `jumpTo()` to `moveCamera()`
- [x] rename `flyTo()` to `animateCamera()`
- [x] Remove click callbacks in favor of the event system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] API changes considered for v0.1.0
1 participant