Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralised Error Handling #1

Closed
DSAghicha opened this issue Oct 28, 2023 · 4 comments · Fixed by #126, #375 or #446 · May be fixed by #475 or #465
Closed

Centralised Error Handling #1

DSAghicha opened this issue Oct 28, 2023 · 4 comments · Fixed by #126, #375 or #446 · May be fixed by #475 or #465
Labels
good first issue Good for newcomers refactoring This label covers all the file restructuring and following the industry best practices

Comments

@DSAghicha
Copy link

Adding a centralized error handler will prevent the application for crashing and becoming unavailable.

@krishnaacharyaa
Copy link
Owner

Hi @DSAghicha
Welcome you onboard :)

Can you kindly elaborate more on the issue, meaning how is the error handled presently and why adding centralised error handling will be beneficial.
So that I can assign this issue to you
And in the PR you can explain your approach and how it will enhance the existing application's error handling.

@DSAghicha
Copy link
Author

  1. Having a centralized error handler, catches any unknown errors and based on criticality, we can also implement adding a mailer which will mail any critical server side error.
  2. Instead of handling error in every single endpoint, it will be in a central method. This will help in effective refactoring of code and implement DRY principles.
  3. It can also, intimate the new contributors about any config issue/mistake that might make.
    Ex. I haven't create the .env file causing my application to crash.
    image
    Here, error handler would inform the member to properly mention the URI in the env file.

@krishnaacharyaa
Copy link
Owner

That seems a really best practice :)
Kindly implement this in all the places we make the api calls, db connection and any potential error prone areas
I'm assigning this issue to you.

@krishnaacharyaa krishnaacharyaa added the refactoring This label covers all the file restructuring and following the industry best practices label Oct 29, 2023
@krishnaacharyaa
Copy link
Owner

Hi @DSAghicha, can you kindly let us know the ETA to resolve this issue, new potential contributors are aiming to solve this otherwise,
Thank you :)

@krishnaacharyaa krishnaacharyaa added the good first issue Good for newcomers label Nov 12, 2023
@mhadv mhadv mentioned this issue Apr 9, 2024
1 task
This was referenced May 21, 2024
@Rohit3Pandey Rohit3Pandey mentioned this issue Jun 3, 2024
1 task
@farukh166 farukh166 mentioned this issue Jun 6, 2024
1 task
@KarthikEdhala KarthikEdhala mentioned this issue Jun 7, 2024
Closed
1 task
@Satvikuser Satvikuser mentioned this issue Jul 8, 2024
1 task
@priyadarshi0811 priyadarshi0811 mentioned this issue Jul 31, 2024
1 task
This was referenced Aug 13, 2024
@Mayank0851 Mayank0851 mentioned this issue Aug 22, 2024
1 task
@SuryaProo SuryaProo mentioned this issue Sep 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment