-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first_try #646
base: master
Are you sure you want to change the base?
first_try #646
Changes from 4 commits
59e8d34
eb1f045
4669948
18d3949
13b66d6
5a68c86
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
from rest_framework.pagination import PageNumberPagination | ||
|
||
|
||
class OrderSetPagination(PageNumberPagination): | ||
page_size = 3 | ||
page_size_query_param = "page_size" | ||
max_page_size = 5 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,15 @@ | ||
from django.db import transaction | ||
from rest_framework import serializers | ||
|
||
from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession | ||
from cinema.models import ( | ||
Genre, | ||
Actor, | ||
CinemaHall, | ||
Movie, | ||
MovieSession, | ||
Ticket, | ||
Order | ||
) | ||
|
||
|
||
class GenreSerializer(serializers.ModelSerializer): | ||
|
@@ -59,6 +68,7 @@ class MovieSessionListSerializer(MovieSessionSerializer): | |
cinema_hall_capacity = serializers.IntegerField( | ||
source="cinema_hall.capacity", read_only=True | ||
) | ||
tickets_available = serializers.IntegerField(read_only=True) | ||
|
||
class Meta: | ||
model = MovieSession | ||
|
@@ -68,13 +78,61 @@ class Meta: | |
"movie_title", | ||
"cinema_hall_name", | ||
"cinema_hall_capacity", | ||
"tickets_available", | ||
) | ||
|
||
|
||
class MovieSessionDetailSerializer(MovieSessionSerializer): | ||
movie = MovieListSerializer(many=False, read_only=True) | ||
cinema_hall = CinemaHallSerializer(many=False, read_only=True) | ||
movie = MovieListSerializer(read_only=True) | ||
cinema_hall = CinemaHallSerializer(read_only=True) | ||
taken_places = serializers.SerializerMethodField() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here better to use nested serializer instead of creating method. Create a serializer that has row and seat fields and pass it here |
||
|
||
def get_taken_places(self, movie_session: MovieSession) -> list: | ||
return [ | ||
{"row": ticket.row, "seat": ticket.seat} | ||
for ticket in movie_session.tickets.all() | ||
] | ||
|
||
class Meta: | ||
model = MovieSession | ||
fields = ("id", "show_time", "movie", "cinema_hall") | ||
fields = ("id", "show_time", "movie", "cinema_hall", "taken_places") | ||
|
||
|
||
class TicketSerializer(serializers.ModelSerializer): | ||
class Meta: | ||
model = Ticket | ||
fields = ("id", "row", "seat", "movie_session") | ||
|
||
def validate(self, attr: dict) -> dict: | ||
Ticket.validate_seats( | ||
attr["seat"], | ||
attr["row"], | ||
attr["movie_session"], | ||
error_to_raise=serializers.ValidationError( | ||
"This seat is already taken" | ||
), | ||
) | ||
return attr | ||
|
||
|
||
class TicketListSerializer(TicketSerializer): | ||
movie_session = MovieSessionListSerializer(read_only=True, many=False) | ||
|
||
|
||
class OrderSerializer(serializers.ModelSerializer): | ||
tickets = TicketSerializer(many=True, allow_empty=False) | ||
|
||
class Meta: | ||
model = Order | ||
fields = ("id", "created_at", "tickets") | ||
|
||
def create(self, validated_data): | ||
with transaction.atomic(): | ||
tickets_data = validated_data.pop("tickets") | ||
order = Order.objects.create(**validated_data) | ||
for ticket_data in tickets_data: | ||
Ticket.objects.create(order=order, **ticket_data) | ||
|
||
|
||
class OrderListSerializer(OrderSerializer): | ||
tickets = TicketListSerializer(many=True, read_only=True) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
def filter_request_to_int(query_params: str) -> list: | ||
return [int(str_id) for str_id in query_params.split(",")] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,7 +124,7 @@ | |
|
||
USE_I18N = True | ||
|
||
USE_TZ = False | ||
USE_TZ = True | ||
|
||
|
||
# Static files (CSS, JavaScript, Images) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove db from remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix indentation everywhere