Avoid surprising mutation and remove Any from the kwargs type. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the types-requests stubs to annotate the kwargs. Ideally we don't import _Names from a stub namespace but let the type checker infer the ParamSpec.kwargs from its use. But ParamSpec can't be used as where a Type is expected.
Was already like this for black. Running tox locally with a local venv in the project directory was failing (and taking unnecessarily long)... Actually still does: flake8 + isort + black > uv 😉
CharString
commented
Sep 18, 2024
| setattr(self, k, v) | ||
| else: | ||
| # store the remainder so we can inject it in the ``request`` method. | ||
| self._request_kwargs[k] = v |
There was a problem hiding this comment.
I chose not to annotate self._request_kwargs as RequestKwargs, because mypy only allows assignment in it with literals. The fact that k came from the same type...
PyRight either is smarter or doesn't seem to mind.
There was a problem hiding this comment.
I'm okay with switching to pyright in CI instead of mypy if that makes life better
CharString
commented
Sep 18, 2024
| another_one = APIClient.configure_from(MyConfig) | ||
|
|
||
| assert one.auth == ("djkhaled", "youplayedyourself") | ||
| assert another_one.auth == ("djkhaled", "youplayedyourself") |
There was a problem hiding this comment.
After reading #3... Does this actually work? Or is this one of the surprises Victorien meant?
There was a problem hiding this comment.
it's a different thing. A surprising one indeed 😬
sergei-maertens
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no gitmoji for happy little accident. But this